Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: route push problem with subscription in prod mode #2234

Merged
merged 2 commits into from
Nov 1, 2019

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented Nov 1, 2019

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@sorrycc sorrycc added the pr(bug) label Nov 1, 2019
@coveralls
Copy link

coveralls commented Nov 1, 2019

Coverage Status

Coverage decreased (-0.2%) to 86.429% when pulling 31f06cc on fix/subscription-execute-in-prod into 4d3ed5e on master.

@codecov-io
Copy link

codecov-io commented Nov 1, 2019

Codecov Report

Merging #2234 into master will decrease coverage by 0.5%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2234      +/-   ##
==========================================
- Coverage   86.32%   85.82%   -0.51%     
==========================================
  Files          18       18              
  Lines         512      515       +3     
  Branches      111      113       +2     
==========================================
  Hits          442      442              
- Misses         56       59       +3     
  Partials       14       14
Impacted Files Coverage Δ
packages/dva/src/index.js 63.79% <0%> (-3.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d3ed5e...c2cf304. Read the comment docs.

@sorrycc sorrycc merged commit 04eae82 into master Nov 1, 2019
@sorrycc sorrycc deleted the fix/subscription-execute-in-prod branch November 1, 2019 13:35
GoToBoy pushed a commit to GoToBoy/dva that referenced this pull request Oct 12, 2023
* fix: route push problem with subscription in prod mode

* fix ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants