Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle raw binary (audio) data when processing response body #20

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

dvcrn
Copy link
Owner

@dvcrn dvcrn commented Feb 17, 2024

When creating audio speech (TTS), OpenAI returns binary data. Add a check to see if you leave it as is, or decode JSON if necessary

Taken over from #18
Fixes #19

francoabaroa and others added 2 commits January 19, 2024 16:05
When creating audio speech (TTS), OpenAI returns binary data. Add a check to see if you leave it as is, or decode JSON if necessary
@dvcrn dvcrn merged commit 1c25dfe into main Apr 2, 2024
2 checks passed
@dvcrn dvcrn deleted the binary-response branch April 2, 2024 00:15
@dvcrn
Copy link
Owner Author

dvcrn commented Apr 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExOpenAI.Audio.create_speech tries to parse response as JSON when it is the raw MP3 string
2 participants