Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

feat: profile merge and retrieve #1353

Merged
merged 10 commits into from
Sep 20, 2023
Merged

feat: profile merge and retrieve #1353

merged 10 commits into from
Sep 20, 2023

Conversation

ethan-sargent
Copy link
Contributor

@ethan-sargent ethan-sargent commented Jul 13, 2023

  • move from sfpowerkit
  • fix: remove useWorkspaces from lerna
  • feat(profiles): merge
  • feat(profiles): include merge and retrieve

Summary generated by Reviewpad on 20 Sep 23 09:07 UTC

This pull request includes the following changes:

  1. The change in the log message of the sfpowerscripts command to sfp.
  2. Changes to the profile_retrieve.json file:
    • Added a new key retriveDelayWarning with a descriptive value.
    • Updated the value of the key deleteFlagDescription.
  3. Changes to the reconcile.ts file in the sfpowerscripts-cli/src/commands/profile directory:
    • Updated import statements.
    • Removed initialization of Messages with the current plugin directory.
    • Revised usage of the Messages framework.
    • Updated command examples to use the "sfp" prefix.
  4. Addition of the retrieve.ts file:
    • Creation of the file.
    • Imports of various modules and libraries.
    • Definition of a class named Retrieve.
    • Definition of flags and required parameters.
    • Definition of an execute method.
  5. Addition of the merge.ts file to the sfpowerscripts-cli/src/commands/profile directory:
    • Creation of the file.
    • Definition of a class named Merge.
    • Definition of flags and required parameters.
    • Definition of an execute method.

Please review these changes carefully. Let me know if you have any further questions or need assistance with anything else.

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Jul 13, 2023
@ethan-sargent ethan-sargent linked an issue Jul 13, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.11% ⚠️

Comparison is base (c915a5c) 46.91% compared to head (f3c46eb) 46.80%.
Report is 36 commits behind head on main.

❗ Current head f3c46eb differs from pull request most recent head 4ff15cb. Consider uploading reports for the commit 4ff15cb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1353      +/-   ##
==========================================
- Coverage   46.91%   46.80%   -0.11%     
==========================================
  Files          70       70              
  Lines        2656     2662       +6     
  Branches      309      310       +1     
==========================================
  Hits         1246     1246              
+ Misses       1408     1386      -22     
- Partials        2       30      +28     
Files Changed Coverage Δ
packages/core/src/git/GitDiffUtil.ts 11.25% <0.00%> (-0.29%) ⬇️
...ages/core/src/package/diff/PackageComponentDiff.ts 12.50% <0.00%> (-0.31%) ⬇️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azlam-abdulsalam azlam-abdulsalam merged commit d783041 into main Sep 20, 2023
4 of 5 checks passed
@azlam-abdulsalam azlam-abdulsalam deleted the fix/profiles_commands branch September 20, 2023 09:10
@azlam-abdulsalam azlam-abdulsalam added this to the August 23 milestone Sep 20, 2023
@reviewpad
Copy link

reviewpad bot commented Sep 20, 2023

Reviewpad Report

‼️ Errors

  • Unconventional commit detected: 'move from sfpowerkit' (68d978a)
  • Unconventional commit detected: 'Merge branch 'main' into fix/profiles_commands' (b8380cb)
  • Unconventional commit detected: 'Revert "fix: remove useWorkspaces from lerna"

This reverts commit a090f91.' (714fa37)

  • Unconventional commit detected: 'Merge branch 'main' into fix/profiles_commands' (2fac32f)
  • Unconventional commit detected: 'Merge branch 'main' into fix/profiles_commands' (b8c9928)
  • Unconventional commit detected: 'Merge branch 'main' into fix/profiles_commands' (4c4e6e2)

⚠️ Warnings

  • Please rebase your pull request on the latest changes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
large Pull request is large waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standalone command to reconcile/merge/retrive profiles
2 participants