feat: use node 18 LTS instead of the latest 20.x version

[rody]

Summary generated by Reviewpad on 11 Oct 23 01:54 UTC

This pull request includes two patches:

1. The first patch updates the Dockerfile for the sfpowerscripts image to use Node.js 18 LTS instead of version 20.x.

2. The second patch modifies the Dockerfile to remove the yarn/sf cache in order to reduce the image size.

Overall, these changes aim to improve the Docker image for the sfpowerscripts build system in the Salesforce environment.

Checklist

All items have to be completed before a PR is merged

• Adhere to Contribution Guidelines
• Updates to Decision Records considered?
• Updates to documentation at DX@Scale Guide considered?
• Tested changes?
• Unit Tests new and existing passing locally?

Rationale

We are not dependent on bleeding edge features from nodejs and a few occasional errors have been reported with the image using v20.x. Therefore, it makes sense to use the LTS version of nodejs for our image.

Image size reduction

@ethan-sargent analyzed the behaviour of sf plugins install and discovered that sf was using a specific cache for yarn. The second commit empties this cache after installing the extra plugins as it is not needed. This change saves ~1.4Gb in the image.

[reviewpad]

Reviewpad Report

⚠️ Warnings

• Please link an issue to the pull request

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (077009f) 46.80% compared to head (ae4efd0) 46.80%.
Report is 3 commits behind head on main.

❗ Current head ae4efd0 differs from pull request most recent head dd699e1. Consider uploading reports for the commit dd699e1 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1421   +/-   ##
=======================================
  Coverage   46.80%   46.80%           
=======================================
  Files          70       70           
  Lines        2662     2662           
  Branches      302      302           
=======================================
  Hits         1246     1246           
  Misses       1414     1414           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[azlam-abdulsalam]

okie