[IND-394] add version to Indexer events #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Liu <will@dydx.exchange>
IND-394 Update protocol Indexer event with version
in Indexer, assume default value of 1 if version is not set |
vincentwschau
approved these changes
Sep 18, 2023
| * @returns | ||
| */ | ||
| export function createIndexerTendermintEvent( | ||
| subtype: string, | ||
| data: string, | ||
| transactionIndex: number, | ||
| eventIndex: number, | ||
| version: number = 1, |
There was a problem hiding this comment.
Is there a cleaner way to do this? I'm worried someone will use the wrong version for protocol one day that will cause an indexer outage
There was a problem hiding this comment.
That was already the case with subtype where it was just a matching of strings between the 2 repos.
There was a problem hiding this comment.
this is only used in tests.
| SubtypeLiquidityTier = "liquidity_tier" | ||
| SubtypeUpdatePerpetual = "update_perpetual" | ||
| SubtypeUpdateClobPair = "update_clob_pair" | ||
| OrderFillEventVersion uint32 = 1 |
There was a problem hiding this comment.
nit add a comment and have the versions in a different section
Christopher-Li
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.