Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-648] fix error string in delaymsg unit test #601

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

tqin7
Copy link
Contributor

@tqin7 tqin7 commented Oct 12, 2023

Changelist

[Describe or list the changes made in this PR]

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

  • If this change affects functionality (features, bug fixes, breaking changes, etc.), update protocol/CHANGELOG.md and/or indexer/CHANGELOG.md appropriately.
  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

@linear
Copy link

linear bot commented Oct 12, 2023

CORE-648 Audit x/delay-msg/

  • Primary crystal
  • Secondary tian

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 12, 2023

Walkthrough

The changes primarily focus on the removal of a duplicated import statement and the correction of a formatting issue in an error message string within the TestDelayMessage function.

Changes

File Path Summary
protocol/x/delaymsg/.../msg_server_test.go Removed a duplicated import for codectypes and fixed a formatting issue in an error message string in the TestDelayMessage function.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
  • Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
    resume reviews, enter @coderabbitai resume as any issue or review comment.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 06733bb and 984941c.
Files selected for processing (1)
  • protocol/x/delaymsg/keeper/msg_server_test.go (2 hunks)
Additional comments (Suppressed): 2
protocol/x/delaymsg/keeper/msg_server_test.go (2)
  • 3-11: The import statements are well-organized and there are no duplicates. The removal of the duplicate import for codectypes is a good catch.

  • 102-106: The error message string has been corrected to properly format the error message. This change improves the readability and clarity of the error message.

- expectedErr: fmt.Errorf("DelayMessageByBlocks failed, err  = %w", TestError),
+ expectedErr: fmt.Errorf("DelayMessageByBlocks failed, err = %w", TestError),

@tqin7 tqin7 merged commit 2a49735 into main Oct 12, 2023
8 of 10 checks passed
@tqin7 tqin7 deleted the tq/core-648 branch October 12, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants