Update mdbook, pulldown-cmark and pulldown-cmark-to-cmark dependencies #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgockel
force-pushed
the
issue/4/build-failure
branch
from
b2cffde
to
38cae7d
Compare
This fixes issue #17, which would cause `cargo build mdbook-graphviz` to fail. This brings packages up to their current latest versions: * pulldown-cmark: From 0.7 to 0.8 * pulldown-cmark-to-cmark: From 5.0 to 7.1 * mdbook: From 0.4.x to ^0.4.14 The mdbook update is required because this version added a parameter named `curly_quotes` to the `new_cmark_parser` function. I elected to set this parameter to `false`, as there does not appear to be configuration in the mdbook package for this yet. Presumably, that will come in the future and it should be copied into this repository.
tgockel
force-pushed
the
issue/4/build-failure
branch
from
38cae7d
to
5eaefd4
Compare
|
Thanks for the quick fix @tgockel I'm kind of surprised that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #17, which would cause
cargo build mdbook-graphviztofail. This brings packages up to their current latest versions:
The mdbook update is required because this version added a parameter
named
curly_quotesto thenew_cmark_parserfunction. I elected toset this parameter to
false, as there does not appear to beconfiguration in the mdbook package for this yet. Presumably, that will
come in the future and it should be copied into this repository.