Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Open in FileManager should select the file/dir #51

Closed
markiewb opened this issue May 4, 2014 · 2 comments
Closed

[Windows] Open in FileManager should select the file/dir #51

markiewb opened this issue May 4, 2014 · 2 comments
Labels
Milestone

Comments

@markiewb
Copy link
Collaborator

markiewb commented May 4, 2014

ACTUAL: file manager is opened, file/dir from NetBeans is NOT selected in the explorer
EXPECTED: file manager is opened, file/dir from NetBeans is selected in the explorer
See http://support.microsoft.com/kb/314853/en

IMHO this should be fixed in https://github.com/dzsessona/oscommands/blob/master/OSCommands/src/com/sessonad/oscommands/commands/Commands.java

@markiewb
Copy link
Collaborator Author

Once dzsessona/oscommands#3 is merged, I can provide a patch and include the new jar file

diff --git a/QuickOpener/src/me/dsnet/quickopener/actions/FileSystem.java b/QuickOpener/src/me/dsnet/quickopener/actions/FileSystem.java
index 5faf775..7e34d7d 100644
--- a/QuickOpener/src/me/dsnet/quickopener/actions/FileSystem.java
+++ b/QuickOpener/src/me/dsnet/quickopener/actions/FileSystem.java
@@ -27,14 +27,14 @@

     @Override
     public void actionPerformed(ActionEvent e) {
-        File toOpen = PathFinder.getActiveFile(dataObj,true);
-        if (toOpen == null) {
+        File file = PathFinder.getActiveFile(dataObj,false);
+        if (file == null) {
             NotifyDescriptor d = new NotifyDescriptor.Message(QuickMessages.NO_FILE_IN_SELECTION,NotifyDescriptor.WARNING_MESSAGE);
             DialogDisplayer.getDefault().notify(d);
             return;
         }
         try {
-            Commands.getPlatform().browseInFileSystem(toOpen);
+            Commands.getPlatform().browseInFileSystemToFileOrDir(file);
         } catch (Exception ex) {}//ex.printStackTrace();}
     }
 }

@markiewb markiewb modified the milestone: Next Jan 21, 2016
@markiewb
Copy link
Collaborator Author

After including #60, I can apply my patch and this issue will be solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant