Merge pull request #2454 from eBay/18.3.0

.changeset/healthy-eyes-trade.md

@@ -0,0 +1,5 @@
+---
+"@ebay/skin": minor
+---
+
+feat(lightbox): add divider over footer

.changeset/lemon-dancers-serve.md

@@ -0,0 +1,5 @@
+---
+"@ebay/skin": minor
+---
+
+feat(file-upload): new module

.changeset/lucky-radios-tie.md

@@ -0,0 +1,5 @@
+---
+"@ebay/skin": minor
+---
+
+feat(icons): modified and added icons

.changeset/stupid-candles-hang.md

@@ -0,0 +1,5 @@
+---
+"@ebay/skin": minor
+---
+
+feat(tourtip): improve contrast of tip container

.changeset/tiny-berries-divide.md

@@ -0,0 +1,5 @@
+---
+"@ebay/skin": minor
+---
+
+docs(tokens): add primitive token disclaimer

.changeset/tricky-hats-bake.md

@@ -0,0 +1,5 @@
+---
+"@ebay/skin": minor
+---
+
+fix(button): update focus outline and offset

.changeset/twenty-buttons-beam.md

@@ -0,0 +1,5 @@
+---
+"@ebay/skin": minor
+---
+
+fix(icon-button): refactored and fixed focus

.changeset/wise-cougars-cross.md

@@ -0,0 +1,5 @@
+---
+"@ebay/skin": minor
+---
+
+feat(table): added sorting, cell types, actions, and inputs

.stylelintrc

@@ -17,32 +17,18 @@
         "no-descending-specificity": null,
         "no-duplicate-selectors": null,
         "rule-empty-line-before": null,
-        "no-invalid-double-slash-comments": null,
         "color-function-notation": "legacy",
         "property-no-vendor-prefix": null,
         "selector-no-vendor-prefix": null,
+        "value-no-vendor-prefix": null,
         "selector-class-pattern": null,
         "alpha-value-notation": "number",
-        "value-no-vendor-prefix": null,
-        "import-notation": "string",
         "declaration-block-no-redundant-longhand-properties": null,
-        "at-rule-empty-line-before": null,
-        "media-feature-range-notation": "prefix",
-        "media-query-no-invalid": null,
-        "at-rule-no-unknown": null,
         "value-keyword-case": [
             "lower",
             {
                 "camelCaseSvgKeywords": true
             }
-        ],
-        "function-no-unknown": [
-            true,
-            {
-                "ignoreFunctions": [
-                    "fade"
-                ]
-            }
         ]
     },
     "overrides": [
@@ -60,12 +46,13 @@
             "rules": {
                 "scss/at-mixin-argumentless-call-parentheses": null,
                 "scss/dollar-variable-pattern": null,
+                "order/properties-alphabetical-order": true,
                 "value-keyword-case": [
                     "lower",
                     {
                         "camelCaseSvgKeywords": true
                     }
-                ],
+                ]
             }
         }
     ]

ICON-CREATION.md

@@ -23,7 +23,7 @@ The viewbox given will be translated to the `width` and `height` that the icons
 ## Step 2: Run scripts
 
 To properly setup the icon after it is placed in the `src/svg/icon` directory, run `node scripts genSVG` from the root of the skin project. This will properly setup the icon in docs, in the `icon.svg` bundle, and generate the CSS needed for the icon.
-Afterward, you should run `npm run build` in order to also copy all those files to `dist`.
+Afterward, you should run `npm run build` in order to also copy all those files to `dist` as well as to the docs.
 
 ## Appendix
 

dist/button/button.css

@@ -22,6 +22,12 @@ button.btn--fixed-height,
 button.btn--truncated {
     height: 40px;
 }
+a.fake-btn:focus-visible,
+button.btn:focus-visible {
+    outline-offset: var(--spacing-25);
+    outline-style: solid;
+    outline-width: var(--spacing-25);
+}
 a.fake-btn:focus:not(:focus-visible),
 button.btn:focus:not(:focus-visible) {
     outline: none;
@@ -134,12 +140,10 @@ button.btn svg.icon {
 }
 a.fake-btn svg.icon:first-child,
 button.btn svg.icon:first-child {
-    -webkit-margin-end: 8px;
     margin-inline-end: 8px;
 }
 a.fake-btn svg.icon:last-child,
 button.btn svg.icon:last-child {
-    -webkit-margin-start: 8px;
     margin-inline-start: 8px;
 }
 a.fake-btn svg.icon:only-child,

dist/carousel/carousel.css

@@ -135,13 +135,11 @@ div.carousel {
 }
 .carousel__control--prev {
     left: calc(var(--spacing-200) * -1);
-    -webkit-margin-end: 1px;
     margin-inline-end: 1px;
 }
 .carousel__control--next {
-    right: calc(var(--spacing-200) * -1);
-    -webkit-margin-start: 1px;
     margin-inline-start: 1px;
+    right: calc(var(--spacing-200) * -1);
 }
 .carousel__control svg {
     color: var(

dist/chart-legend/chart-legend.css

@@ -24,7 +24,6 @@
     content: "";
     display: inline-block;
     height: 10px;
-    -webkit-margin-end: var(--spacing-100);
     margin-inline-end: var(--spacing-100);
     width: 10px;
 }

dist/chip/chip.css

@@ -28,7 +28,6 @@ button.chip__button {
     flex-shrink: 0;
     height: var(--spacing-300);
     line-height: 0;
-    -webkit-margin-end: -8px;
     margin-inline-end: -8px;
     padding: 0;
     width: var(--spacing-300);

dist/chips-combobox/chips-combobox.css

@@ -4,9 +4,7 @@
     border-radius: var(--border-radius-50);
     display: inline-block;
     padding-bottom: var(--spacing-100);
-    -webkit-padding-end: var(--spacing-200);
     padding-inline-end: var(--spacing-200);
-    -webkit-padding-start: var(--spacing-100);
     padding-inline-start: var(--spacing-100);
     padding-top: var(--spacing-100);
     position: relative;
@@ -49,7 +47,6 @@
 }
 
 .chips-combobox .combobox {
-    -webkit-margin-start: calc(var(--spacing-100) * -1);
     margin-inline-start: calc(var(--spacing-100) * -1);
     width: calc(100% + var(--spacing-300));
 }

dist/combobox/combobox.css

@@ -58,7 +58,6 @@ span.combobox {
 
 .combobox__control > button,
 .combobox__control > svg.icon {
-    -webkit-margin-start: 8px;
     margin-inline-start: 8px;
 }
 

dist/cta-button/cta-button.css

@@ -21,6 +21,11 @@ a.cta-btn--fixed-height,
 a.cta-btn--truncated {
     height: 40px;
 }
+a.cta-btn:focus-visible {
+    outline-offset: var(--spacing-25);
+    outline-style: solid;
+    outline-width: var(--spacing-25);
+}
 a.cta-btn:focus:not(:focus-visible) {
     outline: none;
 }
@@ -96,11 +101,9 @@ a.cta-btn svg.icon {
     width: 10px;
 }
 a.cta-btn svg.icon:first-child {
-    -webkit-margin-end: 8px;
     margin-inline-end: 8px;
 }
 a.cta-btn svg.icon:last-child {
-    -webkit-margin-start: 8px;
     margin-inline-start: 8px;
 }
 a.cta-btn svg.icon:only-child {

dist/details/details.css

@@ -40,7 +40,6 @@ summary.details__summary--small {
 }
 
 span.details__icon {
-    -webkit-margin-start: 8px;
     margin-inline-start: 8px;
 }
 span.details__icon[hidden] {

dist/drawer-dialog/drawer-dialog.css

@@ -42,7 +42,6 @@
     overflow-wrap: anywhere;
 }
 .drawer-dialog__header > :last-child:not(:only-child) {
-    -webkit-margin-start: var(--spacing-200);
     margin-inline-start: var(--spacing-200);
 }
 

dist/education-notice/education-notice.css

@@ -30,7 +30,6 @@
     font-weight: 700;
     line-height: 1.5em;
     margin: 0;
-    -webkit-margin-start: var(--spacing-150);
     margin-inline-start: var(--spacing-150);
 }
 
@@ -39,7 +38,6 @@
 }
 
 .education-notice__dismiss {
-    -webkit-margin-start: var(--spacing-150);
     margin-inline-start: var(--spacing-150);
 }
 

dist/eek/eek.css

@@ -125,7 +125,7 @@
     font-size: 8px;
 }
 @media not all and (-webkit-min-device-pixel-ratio: 0),
-    not all and (min-resolution: 0.001dpcm) {
+    not all and (resolution >= 0.001dpcm) {
     @supports (-webkit-appearance: none) {
         .eek__rating {
             text-shadow: none;

dist/field/field.css

@@ -31,7 +31,6 @@ div.field--table {
 }
 
 .field__description--group > :last-child {
-    -webkit-margin-start: 5px;
     margin-inline-start: 5px;
     text-align: right;
 }

dist/file-input/file-input.css

@@ -0,0 +1,105 @@
+div.file-input {
+    display: grid;
+    grid-template-areas: "center";
+    grid-template-columns: 1fr;
+    grid-template-rows: 1fr;
+}
+
+div.file-input__container,
+input.file-input__input[type="file"] {
+    border-radius: var(--file-input-border-radius, var(--border-radius-100));
+    grid-area: center;
+}
+
+div.file-input__container {
+    background-color: var(
+        --file-input-background-color,
+        var(--color-background-secondary)
+    );
+    border: 1px dashed;
+    display: flex;
+    flex-direction: row;
+    gap: var(--spacing-100);
+    min-width: -moz-fit-content;
+    min-width: fit-content;
+    padding: var(--spacing-200);
+    pointer-events: none;
+    z-index: 1;
+}
+
+div.file-input___container--dragged-over {
+    background-color: var(
+        --file-input-dragged-over-background-color,
+        var(--color-background-tertiary)
+    );
+}
+
+div.file-input__upload-icon {
+    align-self: center;
+    background-color: var(
+        --file-input-upload-icon-background-color,
+        var(--color-background-primary)
+    );
+    border-radius: 99px;
+    padding: var(--spacing-150);
+}
+
+div.file-input__upload-icon svg {
+    fill: var(--file-input-upload-icon-fill, var(--color-foreground-primary));
+    height: var(--spacing-300);
+    width: var(--spacing-300);
+}
+
+div.file-input__content {
+    align-items: start;
+    display: flex;
+    flex-direction: column;
+    flex-grow: 1;
+    justify-content: center;
+}
+
+.file-input__content-header {
+    color: var(
+        --file-input-content-header-color,
+        var(--color-foreground-primary)
+    );
+    font-size: var(--font-size-14);
+    font-weight: 700;
+    line-height: var(--spacing-250);
+    margin-block: 0 var(--spacing-50);
+}
+
+span.file-input__content-subheader {
+    color: var(
+        --file-input-content-subheader-color,
+        var(--color-foreground-secondary)
+    );
+    font-size: var(--font-size-12);
+    font-weight: 400;
+    line-height: var(--spacing-200);
+    -webkit-margin-after: var(--spacing-100);
+    margin-block-end: var(--spacing-100);
+}
+
+span.file-input__content-cta {
+    -webkit-text-decoration-line: underline;
+    text-decoration-line: underline;
+}
+
+@media screen and (min-width: 768px) {
+    div.file-input__container {
+        gap: var(--spacing-300);
+    }
+    div.file-input__container,
+    div.file-input__upload-icon {
+        padding: var(--spacing-300);
+    }
+    .file-input__content-header {
+        font-size: var(--font-size-16);
+        line-height: var(--spacing-300);
+    }
+    span.file-input__content-subheader {
+        font-size: var(--font-size-14);
+        line-height: var(--spacing-250);
+    }
+}