Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17839] Update runner and GCC version for Thread Sanitizer job #3406

Merged
merged 3 commits into from
Mar 31, 2023

Conversation

jsan-rt
Copy link
Contributor

@jsan-rt jsan-rt commented Mar 27, 2023

Currently, the configured runner OS for the Thread Sanitizer Github Action is Ubuntu 20.04. This PR updates it to 22.04 and update GCC to version 12.1 (from the 11.3 default) to prevent several false positives triggered by the old version.

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • [N/A] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [N/A] Any new/modified methods have been properly documented using Doxygen.
  • [N/A] Changes are ABI compatible.
  • [N/A] Changes are API compatible.
  • [N/A] New feature has been added to the versions.md file (if applicable).
  • [N/A] New feature has been documented/Current behavior is correctly described in the documentation.
  • [N/A] Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt jsan-rt marked this pull request as ready for review March 27, 2023 13:29
…in Ubuntu 22.04 runner images

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@JLBuenoLopez JLBuenoLopez added this to the v2.10.1 milestone Mar 29, 2023
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green TSan job

@EduPonz EduPonz merged commit d82c525 into master Mar 31, 2023
@EduPonz EduPonz deleted the sanitizers/update-runner-version branch March 31, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants