Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: process crash can potentially result in port abnormalities. #4737

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: process crash can potentially result in port abnormalities. #4737

wants to merge 1 commit into from

Conversation

nichoal
Copy link

@nichoal nichoal commented Apr 26, 2024 •
edited
Loading

Fix: process crash can potentially result in port abnormalities.

  • Cleaning up zombie ports will delete shared segment which could be used for writing by other participants. In such cases, using the previously deleted shared memory segment to continue transmitting data can lead to issues.

Signed-off-by: nichoal 31479100+nichoal@users.noreply.github.com

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are ABI compatible.
  • ❌ Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@nichoal
Fix: process crash and restart can potentially result in port abnorma…
bcda362 
…lities.[skip ci]

* Cleaning up zombie ports will delete shared segment which  could be used for writing by other participants.  In such cases, using the previously deleted shared memory segment to continue transmitting data can lead to issues.

Signed-off-by: nichoal 31479100+nichoal@users.noreply.github.com
Signed-off-by: sunhaihui <sunhaihui@zhidaoauto.com>
@nichoal nichoal force-pushed the hot_fix/devel_nichoal_fix_shm_port_abnormal branch from a5849ef to bcda362 Compare April 26, 2024 15:24
@nichoal nichoal changed the title Fix: process crash can potentially result in port abnormalities.[skip ci] Fix: process crash can potentially result in port abnormalities. [ skip ci ] Apr 26, 2024
@nichoal nichoal changed the title Fix: process crash can potentially result in port abnormalities. [ skip ci ] Fix: process crash can potentially result in port abnormalities. [ci skip] Apr 26, 2024
@nichoal nichoal changed the title Fix: process crash can potentially result in port abnormalities. [ci skip] Fix: process crash can potentially result in port abnormalities. Jul 25, 2024
@nichoal
Copy link
Author

nichoal commented Jul 25, 2024

@MiguelCompany could you help me to review the codes,please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nichoal