Fix XQuery snippets #213
Merged
Fix XQuery snippets #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tabs are required before code, according to https://cloud9-sdk.readme.io/docs/snippets#section-snippets. The spaces used in two snippets were throwing off the snippet parser.
dizzzz
approved these changes
Jan 23, 2019
|
@dizzzz Thank you! Could you please merge it? |
lguariento
approved these changes
Feb 7, 2019
|
yes sir :-) |
|
@dizzzz @lguariento Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Ace snippets documentation at https://cloud9-sdk.readme.io/docs/snippets#section-snippets, code in the snippets file must be preceded by a tab, not spaces. The spaces used in two snippets in the query.snippets file introduced in #100 were throwing off the snippet parser.
Test: In an XQuery editor pane, type "output" and hitting control-space to trigger the snippet generator. Before, the json snippet would appear instead of the expected output namespace declaration. With this PR, the expected output namespace declaration is returned.
Note: This does not fix the bug reported in #105, which still affects the current version of eXide.