Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duncdrum patch 1 #229

Merged
merged 3 commits into from
Sep 3, 2019
Merged

Duncdrum patch 1 #229

merged 3 commits into from
Sep 3, 2019

Conversation

duncdrum
Copy link
Contributor

@duncdrum duncdrum commented Sep 3, 2019

No description provided.

adamretter
adamretter reviewed Sep 3, 2019
View reviewed changes
Copy link
Member

@adamretter adamretter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering why 4.7.1 and not 5.0.0?

@duncdrum
Copy link
Contributor Author

duncdrum commented Sep 3, 2019 •
edited
Loading

4.7.1 checks fo backwards compatibility with v4 series. release. is 5.0.0 and latest is 5.1.0-snapshot are moving targets.
since we have semver-min="4.0.0" we should test that, if we bump to higher semver we can disable v4 checks

@adamretter adamretter merged commit c858878 into develop Sep 3, 2019
@duncdrum duncdrum deleted the duncdrum-patch-1 branch September 3, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamretter adamretter adamretter left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duncdrum @adamretter