Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from upstream repo facebookincubator/create-react-app #2

Merged
merged 19 commits into from
Nov 18, 2016
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
b284377
Encourage people to try recent npm
gaearon Oct 24, 2016
91e616e
Point people to npm Windows instructions
gaearon Oct 25, 2016
75d1585
Add next.js to Alternatives
gaearon Oct 25, 2016
ca443ab
Enable compression on webpack-dev-server (#966) (#968)
frontsideair Oct 28, 2016
91c8650
Gently nudge users towards https by default (#974)
Swizec Oct 28, 2016
0bd593b
Catch and noop call to open web browser. (#964)
spadin Oct 28, 2016
a0efbeb
Add collectCoverageFrom option to collect coverage on files without a…
mackbyte Oct 28, 2016
fcda24e
Always build before deploying to gh-pages (#959)
dsernst Oct 28, 2016
8a5c50d
Fixes https://github.com/facebookincubator/create-react-app/issues/95…
vadzim Oct 28, 2016
7ce4b6e
Check for presence of folders before continuing eject. Closes #939. (…
heldinz Oct 28, 2016
6bda4b9
Remove custom babel-loader cache dir config (#983)
fson Oct 29, 2016
e3b6966
Allow webpack 2 as peerDependency in react-dev-utils (#963)
Oct 31, 2016
b855cc3
Add Gatsby to alternatives (#995)
KyleAMathews Oct 31, 2016
79160b8
Remove redundant `function` from export statement (#996)
gnowoel Nov 1, 2016
da1d534
Update babel-present-env and use node: 'current' as target (#1051)
valscion Nov 17, 2016
80fe767
Clears the usage of react-jsx-source & react-jsx-self (#992)
sathishsoundharajan Nov 17, 2016
4a7f78e
Remove unnecessary transform plugins for object spread to work (#1052)
valscion Nov 17, 2016
b9c9aed
Fix chrome tab reuse (#1035)
Nov 17, 2016
bcc469c
Support Yarn (#898)
fson Nov 17, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Always build before deploying to gh-pages (facebook#959)
* Always build before deploying to gh-pages

* Add line to gh-pages deploy docs about CNAME file

* Remove spaces in npm run command for Windows

* Grammar nit

* Minor tweaks
  • Loading branch information
dsernst authored and gaearon committed Oct 28, 2016
commit fcda24eee879460095e35e6e5b66269cca8b8094
8 changes: 6 additions & 2 deletions packages/react-scripts/template/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -887,7 +887,7 @@ Open your `package.json` and add a `homepage` field:
**The above step is important!**<br>
Create React App uses the `homepage` field to determine the root URL in the built HTML file.

Now, whenever you run `npm run build`, you will see a cheat sheet with instructions on how to deploy to GitHub pages.
Now, whenever you run `npm run build`, you will see a cheat sheet with instructions on how to deploy to GitHub Pages.

To publish it at [https://myusername.github.io/my-app](https://myusername.github.io/my-app), run:

Expand All @@ -901,16 +901,20 @@ Add the following script in your `package.json`:
// ...
"scripts": {
// ...
"deploy": "gh-pages -d build"
"deploy": "npm run build&&gh-pages -d build"
}
```

(Note: the lack of whitespace is intentional.)

Then run:

```sh
npm run deploy
```

You can configure a custom domain with GitHub Pages by adding a `CNAME` file to the `public/` folder.

Note that GitHub Pages doesn't support routers that use the HTML5 `pushState` history API under the hood (for example, React Router using `browserHistory`). This is because when there is a fresh page load for a url like `http://user.github.io/todomvc/todos/42`, where `/todos/42` is a frontend route, the GitHub Pages server returns 404 because it knows nothing of `/todos/42`. If you want to add a router to a project hosted on GitHub Pages, here are a couple of solutions:
* You could switch from using HTML5 history API to routing with hashes. If you use React Router, you can switch to `hashHistory` for this effect, but the URL will be longer and more verbose (for example, `http://user.github.io/todomvc/#/todos/42?_k=yknaj`). [Read more](https://github.com/reactjs/react-router/blob/master/docs/guides/Histories.md#histories) about different history implementations in React Router.
* Alternatively, you can use a trick to teach GitHub Pages to handle 404 by redirecting to your `index.html` page with a special redirect parameter. You would need to add a `404.html` file with the redirection code to the `build` folder before deploying your project, and you’ll need to add code handling the redirect parameter to `index.html`. You can find a detailed explanation of this technique [in this guide](https://github.com/rafrex/spa-github-pages).
Expand Down