Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I2S Fix Builtin DAC&PDM on ESP32 & compiling warning ESP32-C3 #461

Merged
merged 4 commits into from
Dec 18, 2021
Merged

I2S Fix Builtin DAC&PDM on ESP32 & compiling warning ESP32-C3 #461

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dfcdd79
Update AudioOutputI2S.cpp
FedericoBusero Dec 6, 2021
023900d
Update AudioOutputSPDIF.cpp
FedericoBusero Dec 6, 2021
0399d17
Fix PDM & DAC mode ESP32
FedericoBusero Dec 7, 2021
9132391
Update AudioOutputI2S.cpp
FedericoBusero Dec 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update AudioOutputI2S.cpp
  • Loading branch information
@FedericoBusero
FedericoBusero authored Dec 6, 2021
commit dfcdd792c3ade3d8f2b1c3ce5eba42d55c1b2377
8 changes: 8 additions & 0 deletions src/AudioOutputI2S.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,15 +193,23 @@ bool AudioOutputI2S::begin(bool txDAC)
i2s_comm_format_t comm_fmt;
if (output_mode == INTERNAL_DAC)
{
#if ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(4, 2, 0)
comm_fmt = (i2s_comm_format_t) I2S_COMM_FORMAT_STAND_MSB;
#else
comm_fmt = (i2s_comm_format_t) I2S_COMM_FORMAT_I2S_MSB;
#endif
}
else if (lsb_justified)
{
comm_fmt = (i2s_comm_format_t) (I2S_COMM_FORMAT_I2S | I2S_COMM_FORMAT_I2S_LSB);
}
else
{
#if ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(4, 2, 0)
comm_fmt = (i2s_comm_format_t) (I2S_COMM_FORMAT_STAND_I2S);
#else
comm_fmt = (i2s_comm_format_t) (I2S_COMM_FORMAT_I2S | I2S_COMM_FORMAT_I2S_MSB);
#endif
}

i2s_config_t i2s_config_dac = {
Expand Down