Skip to content

Commit

Permalink
Clean up some style in nedbat#782, switch_context
Browse files Browse the repository at this point in the history
  • Loading branch information
nedbat committed Apr 28, 2019
1 parent 8810f05 commit 50ebf93
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 28 deletions.
41 changes: 18 additions & 23 deletions tests/test_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -499,13 +499,14 @@ def test_source_and_include_dont_conflict(self):
# There should be no exception. At one point, report() threw:
# CoverageException: --include and --source are mutually exclusive
cov.report()
self.assertEqual(self.stdout(), textwrap.dedent("""\
expected = textwrap.dedent("""\
Name Stmts Miss Cover
---------------------------
b.py 1 0 100%
"""))
""")
self.assertEqual(expected, self.stdout())

def make_testsuite(self):
def make_test_files(self):
"""Create a simple file representing a method with two tests.
Returns absolute path to the file.
Expand All @@ -524,7 +525,7 @@ def test_multiply_six():
def test_switch_context_testrunner(self):
# This test simulates a coverage-aware test runner,
# measuring labeled coverage via public API
self.make_testsuite()
self.make_test_files()

# Test runner starts
cov = coverage.Coverage()
Expand All @@ -548,24 +549,21 @@ def test_switch_context_testrunner(self):
# Labeled data is collected
data = cov.get_data()
self.assertEqual(
sorted(data.measured_contexts()),
[u'', u'multiply_six', u'multiply_zero'])
[u'', u'multiply_six', u'multiply_zero'],
sorted(data.measured_contexts())
)

filenames = self.get_measured_filenames(data)
suite_filename = filenames['testsuite.py']

self.assertEqual(
data.lines(suite_filename, context="multiply_six"),
[2, 8])
self.assertEqual(
data.lines(suite_filename, context="multiply_zero"),
[2, 5])
self.assertEqual([2, 8], data.lines(suite_filename, context="multiply_six"))
self.assertEqual([2, 5], data.lines(suite_filename, context="multiply_zero"))

def test_switch_context_with_static(self):
# This test simulates a coverage-aware test runner,
# measuring labeled coverage via public API,
# with static label prefix.
self.make_testsuite()
self.make_test_files()

# Test runner starts
cov = coverage.Coverage(context="mysuite")
Expand All @@ -589,31 +587,28 @@ def test_switch_context_with_static(self):
# Labeled data is collected
data = cov.get_data()
self.assertEqual(
[u'mysuite', u'mysuite|multiply_six', u'mysuite|multiply_zero'],
sorted(data.measured_contexts()),
[u'mysuite', u'mysuite:multiply_six', u'mysuite:multiply_zero'])
)

filenames = self.get_measured_filenames(data)
suite_filename = filenames['testsuite.py']

self.assertEqual(
data.lines(suite_filename, context="mysuite:multiply_six"),
[2, 8])
self.assertEqual(
data.lines(suite_filename, context="mysuite:multiply_zero"),
[2, 5])
self.assertEqual([2, 8], data.lines(suite_filename, context="mysuite|multiply_six"))
self.assertEqual([2, 5], data.lines(suite_filename, context="mysuite|multiply_zero"))

def test_switch_context_unstarted(self):
# Coverage must be started to switch context

msg = "Cannot switch context, coverage is not started"
cov = coverage.Coverage()
with self.assertRaises(CoverageException):
with self.assertRaisesRegex(CoverageException, msg):
cov.switch_context("test1")

cov.start()
cov.switch_context("test2")

cov.stop()
with self.assertRaises(CoverageException):
with self.assertRaisesRegex(CoverageException, msg):
cov.switch_context("test3")


Expand Down
10 changes: 5 additions & 5 deletions tests/test_plugins.py
Original file line number Diff line number Diff line change
Expand Up @@ -925,7 +925,7 @@ def coverage_init(reg, options):
reg.add_dynamic_context(Plugin())
""")

def make_testsuite(self):
def make_test_files(self):
"""Make some files to use while testing dynamic context plugins."""
self.make_file("rendering.py", """\
def html_tag(tag, content):
Expand Down Expand Up @@ -979,7 +979,7 @@ def run_all_functions(self, cov, suite_name): # pragma: nested

def test_plugin_standalone(self):
self.make_plugin_capitalized_testnames('plugin_tests.py')
self.make_testsuite()
self.make_test_files()

# Enable dynamic context plugin
cov = coverage.Coverage()
Expand Down Expand Up @@ -1010,7 +1010,7 @@ def test_plugin_standalone(self):

def test_static_context(self):
self.make_plugin_capitalized_testnames('plugin_tests.py')
self.make_testsuite()
self.make_test_files()

# Enable dynamic context plugin for coverage with named context
cov = coverage.Coverage(context='mytests')
Expand All @@ -1031,7 +1031,7 @@ def test_static_context(self):

def test_plugin_with_test_function(self):
self.make_plugin_capitalized_testnames('plugin_tests.py')
self.make_testsuite()
self.make_test_files()

# Enable both a plugin and test_function dynamic context
cov = coverage.Coverage()
Expand Down Expand Up @@ -1066,7 +1066,7 @@ def test_plugin_with_test_function(self):
def test_multiple_plugins(self):
self.make_plugin_capitalized_testnames('plugin_tests.py')
self.make_plugin_track_render('plugin_renderers.py')
self.make_testsuite()
self.make_test_files()

# Enable two plugins
cov = coverage.Coverage()
Expand Down

0 comments on commit 50ebf93

Please sign in to comment.