Update lsp-types to 0.97 and add notebook support
#401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required by dashmap 5.5
Required by async-tungstenite 0.23.0
|
@zebreus gluon pr has been merged? |
|
@planetoryd The required features were added in lsp-types 0.96. I rebased this PR onto #412 which updates lsp-types to 0.95 (the first five commits), then I added an commit which updates lsp-types to 0.97, the last commit on the branch is the one that adds notebook support. |
zebreus
changed the title
zebreus
changed the title
lsp-types to 0.97 and add notebook support
|
@ebkalderon Can this be merged? We would like to begin work on denoland/vscode_deno#932. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for notebook document synchronization which was added in LSP 3.17
This is still draft, because lsp-types currently does not support notebook document synchronization. gluon-lang/lsp-types#268 but still has a few issues, so this PR currently overrides the lsp-types dependecy.