Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subdirectory executable support to direct game runner #1270

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ethangreen-dev
Copy link
Contributor

Simple change, this introduces nested subdir support to the direct game runner. This means that games defined within GameManager.ts can refer to executable path(s) as relative paths, rooted by the game directory itself.

This change is primarily intended to support the Nickel modloader, whose executable is located at GAME/Nickel/Nickel.exe.

Simple change, this introduces nested subdir support to the direct game
runner. This means that games defined within GameManager.ts can refer to
executable path(s) as relative paths, rooted by the game directory
itself.

This change is primarily intended to support the Nickel modloader, whose
executable is nested within `Nickel/Nickel.exe`.
Copy link
Collaborator

@MythicManiac MythicManiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we couldn't change the game definition config to include an option for configuring the exe dirpath? That would seem like a more reasonable approach to me here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants