test readr read_lines in readISO19139

eblondel · Jun 2, 2022 · 98de2d9 · 98de2d9
1 parent 1df0aa5
commit 98de2d9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -10,7 +10,7 @@ Description: Provides facilities to handle reading and writing of geographic met
  and encoded using the ISO 19139 (XML) standard. It includes also a facility to check
  the validity of ISO 19139 XML encoded metadata.
 Depends: R (>= 3.3.0)
-Imports: methods, R6, XML, httr, jsonlite, keyring
+Imports: methods, R6, XML, httr, jsonlite, keyring, readr
 Suggests: sf, ncdf4, EML, emld, units, testthat, roxygen2
 License: MIT + file LICENSE
 URL: https://github.com/eblondel/geometa/wiki

diff --git a/R/readISO19139.R b/R/readISO19139.R
@@ -40,7 +40,7 @@ readISO19139 <- function(file = NULL, url = NULL, raw = FALSE){
     doc <- content(req, as = "text", encoding = encoding)
     raw_xml <- XML::xmlParse(doc, encoding = encoding, addFinalizer = FALSE)
   }else{
-    raw_xml <- suppressWarnings(readLines(file, encoding = encoding))
+    raw_xml <- readr::read_lines(file)
     raw_xml <- paste0(raw_xml, collapse="") 
     if(Encoding(raw_xml) != "UTF-8") Encoding(raw_xml) <- "UTF-8"
     if(Encoding(raw_xml) == "unknown"){