Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect single collection detail page to Django #1070

Merged
merged 10 commits into from
Sep 12, 2024
Merged

Connect single collection detail page to Django #1070

merged 10 commits into from
Sep 12, 2024

Conversation

blms
Copy link
Contributor

@blms blms commented Sep 10, 2024 •
edited
Loading

In this PR

  • fix for summernote wysiwyg rich text editor
  • connect collection label, header, summary to frontend
  • connect collection volumes list to existing volumes list logic

@blms blms changed the title Feature/collection page django Connect single collection detail page to Django Sep 11, 2024
@blms blms marked this pull request as ready for review September 11, 2024 18:26
@blms blms requested a review from yl5682 September 11, 2024 18:26
@yl5682 yl5682 merged commit 270f8b0 into feature/956-single-vol-search Sep 12, 2024
yl5682
yl5682 reviewed Sep 12, 2024
View reviewed changes
Copy link
Contributor

@yl5682 yl5682 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tested the PR and it worked great. I added two commits to address cosmetic issues related to the collection details page. They have been merged.

@blms blms deleted the feature/collection-page-django branch September 12, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yl5682 yl5682 yl5682 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blms @yl5682