This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
Avoid conflicts from build-essential #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ensure_packages('build-essential', ...)` was conflicting with
another usage of `ensure_packages('build-essential')` elsewhere in our
puppet repository. This change declares the desired dependency in a way
that does not require setting parameters on the package resource.
Because the parameters are removed, the ensure_packages becomes more
generic and less likely to conflict with other modules that might define
the same package resource.
dwerder
added a commit
that referenced
this pull request
Oct 13, 2015
Avoid conflicts from build-essential
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ensure_packages('build-essential', ...)was conflicting withanother usage of
ensure_packages('build-essential')elsewhere in ourpuppet repository. This change declares the desired dependency in a way
that does not require setting parameters on the package resource.
Because the parameters are removed, the ensure_packages becomes more
generic and less likely to conflict with other modules that might define
the same package resource.