Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Use correct binary for packaging plugin into zip container #596

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

vzhukovs
Copy link
Contributor

@vzhukovs vzhukovs commented Jan 8, 2020

What does this PR do?

This changes proposal fix build of che-theia after upgrade yarn to version 1.19.1

The problem was occurred when user upgrades yarn to version 1.19.1. Plugins are using @theia/plugin-packager as a dependency to pack themselves to zip container. On 1.19.0 there isn't any problem, because @theia/plugin-packager dependency provides theia:plugin and theia-plugin binaries. But on 1.19.1 there is only theia-plugin binary.

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

What issues does this PR fix or reference?

eclipse-che/che#15552

Release Notes

N/A

Docs PR

N/A

@vzhukovs vzhukovs added the kind/bug Something isn't working label Jan 8, 2020
@vzhukovs vzhukovs self-assigned this Jan 8, 2020
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@vzhukovs vzhukovs merged commit 26e0221 into master Jan 13, 2020
@vzhukovs vzhukovs deleted the che#15552 branch January 13, 2020 11:40
vinokurig pushed a commit that referenced this pull request Apr 6, 2021
Signed-off-by: Lining Pan <lining_pan@outlook.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants