Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project structure: inline dataloading module #1833

Closed
2 tasks done
Tracked by #1596
ndr-brt opened this issue Aug 16, 2022 · 0 comments · Fixed by #1846
Closed
2 tasks done
Tracked by #1596

Project structure: inline dataloading module #1833

ndr-brt opened this issue Aug 16, 2022 · 0 comments · Fixed by #1846
Assignees
Labels
refactoring Cleaning up code and dependencies
Milestone

Comments

@ndr-brt
Copy link
Member

ndr-brt commented Aug 16, 2022

Feature Request

Since the introduction of the data-management api, the dataloading mechanism seems to be not needed anymore.
The module should be inlined:

  • AssetEntry and DataLoader will be moved to the spi
  • AssetLoader and ContractDefinitionLoader will be inlined to their extenders (AssetIndex and ContractDefinitionStore)
  • the rest of the module and the data-loader-cli will be removed

Which Areas Would Be Affected?

core

Why Is the Feature Desired?

cleanup

Solution Proposal

Type of Issue

cleanup

Checklist

  • assigned appropriate label?
  • Do NOT select a milestone or an assignee!
@ndr-brt ndr-brt added the refactoring Cleaning up code and dependencies label Aug 16, 2022
@ndr-brt ndr-brt added this to the Milestone 6 milestone Aug 16, 2022
@ndr-brt ndr-brt self-assigned this Aug 16, 2022
@ndr-brt ndr-brt mentioned this issue Aug 16, 2022
18 tasks
@ndr-brt ndr-brt changed the title Project structure: inline dataloading Project structure: inline dataloading module Aug 16, 2022
@ndr-brt ndr-brt mentioned this issue Aug 18, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant