Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Inline
extensions/dataloading
method moving its content to thespi
.Remove unused
data-loader-cli
launcherWhy it does that
Cleanup
Further notes
DataSink
interface, as its name could be misleading since there's anotherDataSink
interface in the data-plane-spiAssetIndex
andContractDefinitionStore
hierarchies, but in the future I would get rid also of theAssetLoader
andContractDefinitionLoader
interfaces as they are not useful anymore. Seemed too much for this PR, probably better to do that after the project structure review.Linked Issue(s)
Closes #1833
Checklist
no-changelog
)