Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename http-receiver extension #2229

Closed
ndr-brt opened this issue Nov 23, 2022 · 3 comments · Fixed by #2282
Closed

Rename http-receiver extension #2229

ndr-brt opened this issue Nov 23, 2022 · 3 comments · Fixed by #2282
Assignees
Labels
refactoring Cleaning up code and dependencies

Comments

@ndr-brt
Copy link
Member

ndr-brt commented Nov 23, 2022

Feature Request

The http-receiver is not really self-explainatory, it could be renamed to data-plane-transfer-sync-http-edr or something like this. Maybe it's too verbose, but I was wondering if we need that data-plane prefix on the data-plane-transfer-* extensions.

Which Areas Would Be Affected?

extensions

Why Is the Feature Desired?

comprehensiveness

Solution Proposal

@bscholtes1A
Copy link
Contributor

maybe dpf-transfer instead of data-plane-transfer?
Would shorten a bit...

@ndr-brt
Copy link
Member Author

ndr-brt commented Nov 23, 2022

to be honest, I don't think data-plane should be mentioned, it's misleading, building a control-plane but defining data-plane (or dpf ) dependencies on it... at the end we're talking about providing transfer capabilities to the control plane.
I'd propose:

  • data-plane-transfer-client -> transfer-client
  • data-plane-transfer-sync -> transfer-sync
  • http-receiver -> transfer-sync-http-edr-receiver

@jimmarino
Copy link
Contributor

+1. transfer-sync-http-edr-receiver is also verbose. How about transfer-sync-receiver?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
4 participants