Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(httpReceiver): rename module http-receiver to transfer-pull-http-receiver #2282

Merged

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Dec 2, 2022

What this PR changes/adds

Rename module http-receiver to transfer-pull-http-receiver

Why it does that

comprehensiveness

Further notes

While renaming I've added a test on HttpEndpointDataReferenceReceiver

Linked Issue(s)

Closes #2229

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

@wolf4ood wolf4ood self-assigned this Dec 2, 2022
@wolf4ood wolf4ood added the refactoring Cleaning up code and dependencies label Dec 2, 2022
@wolf4ood wolf4ood temporarily deployed to Azure-dev December 2, 2022 15:54 Inactive
@ndr-brt
Copy link
Member

ndr-brt commented Dec 5, 2022

Since with the last PR by @bscholtes1A we better shaped the terminology for transfer types as "consumer pull" and "provider push", I'd propose to switch sync with pull, to keep an uniform terminology. wdyt?

@wolf4ood wolf4ood force-pushed the refactor/2229_rename_http_receiver branch from 814717e to d17d5ed Compare December 5, 2022 09:02
@wolf4ood wolf4ood temporarily deployed to Azure-dev December 5, 2022 09:02 Inactive
@wolf4ood wolf4ood force-pushed the refactor/2229_rename_http_receiver branch from d17d5ed to 8f6a985 Compare December 5, 2022 09:06
@wolf4ood wolf4ood temporarily deployed to Azure-dev December 5, 2022 09:07 Inactive
@wolf4ood wolf4ood changed the title refactor(httpReceiver): rename module http-receiver to transfer-sync-receiver refactor(httpReceiver): rename module http-receiver to transfer-pull-receiver Dec 5, 2022
@wolf4ood wolf4ood force-pushed the refactor/2229_rename_http_receiver branch from 8f6a985 to f96c2f5 Compare December 5, 2022 09:26
@wolf4ood wolf4ood temporarily deployed to Azure-dev December 5, 2022 09:26 Inactive
@wolf4ood wolf4ood marked this pull request as ready for review December 5, 2022 09:47
@bscholtes1A
Copy link
Contributor

I would still keep the term http in the extension name, as this is one possible type of receiver but we might have other not relying on http, e.g. a receiver putting the EDR into a Vault...

@wolf4ood
Copy link
Contributor Author

wolf4ood commented Dec 5, 2022

@bscholtes1A transfer-pull-http-receiver ?

@wolf4ood wolf4ood force-pushed the refactor/2229_rename_http_receiver branch from f96c2f5 to e965d5b Compare December 5, 2022 10:53
@wolf4ood wolf4ood changed the title refactor(httpReceiver): rename module http-receiver to transfer-pull-receiver refactor(httpReceiver): rename module http-receiver to transfer-pull-http-receiver Dec 5, 2022
@wolf4ood wolf4ood temporarily deployed to Azure-dev December 5, 2022 10:53 Inactive
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another proposal, since there's also the transfer-data-plane, a transfer folder containing both the extension could make everything tidier

@wolf4ood
Copy link
Contributor Author

wolf4ood commented Dec 5, 2022

@ndr-brt make sense, will do

@wolf4ood wolf4ood temporarily deployed to Azure-dev December 5, 2022 14:04 Inactive
@wolf4ood wolf4ood requested a review from ndr-brt December 5, 2022 14:18
@bscholtes1A bscholtes1A merged commit 0366295 into eclipse-edc:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename http-receiver extension
4 participants