Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve little flaws in BaseRuntime #4060

Closed
ndr-brt opened this issue Mar 28, 2024 · 2 comments · Fixed by #4061
Closed

Solve little flaws in BaseRuntime #4060

ndr-brt opened this issue Mar 28, 2024 · 2 comments · Fixed by #4061
Assignees
Labels
feature_request New feature request, awaiting triage triage all new issues awaiting classification
Milestone

Comments

@ndr-brt
Copy link
Member

ndr-brt commented Mar 28, 2024

Feature Request

Currently there are two little flaws in the BaseRuntime that could be solved:

  • the System.exit call has no reason to be and it's better to replace it with an extension throwing, that will help the caller to understand what happened. as a positive side effect this will also provide better output on the e2e tests when they fail for runtime issues (now they fall silently)
  • the HealthCheckService is currently mandatory but this does not look like a good practice, because there could be the necessity to start a Runtime without that service, but now it causes an unavoidable exception.

Which Areas Would Be Affected?

boot

Why Is the Feature Desired?

Are there any requirements?

Solution Proposal

If possible, provide a (brief!) solution proposal.

@ndr-brt ndr-brt added feature_request New feature request, awaiting triage triage all new issues awaiting classification labels Mar 28, 2024
@ndr-brt ndr-brt added this to the Milestone 15 milestone Mar 28, 2024
@ndr-brt ndr-brt self-assigned this Mar 28, 2024
@jimmarino
Copy link
Contributor

Can we deal with the Healthcheck service after I split the boot services from the core services? The System.exit can be addressed independently.

@ndr-brt
Copy link
Member Author

ndr-brt commented Mar 28, 2024

@jimmarino I already opened a PR, but it can wait, no problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature_request New feature request, awaiting triage triage all new issues awaiting classification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants