Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime): avoid system exit and make health check service optional #4061

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Mar 28, 2024

What this PR changes/adds

Makes runtime error finish with an exception.
Make HealthCheckService optional

Why it does that

Explained in #4060

Further notes

  • made the BaseRuntimeFixture simpler by removing custom logic and dealing with mocking of ServiceLocator

Linked Issue(s)

Closes #4060

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the enhancement New feature or request label Mar 28, 2024
@ndr-brt ndr-brt requested a review from wolf4ood March 28, 2024 10:10
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 74.52%. Comparing base (7f20ba5) to head (a804eee).
Report is 187 commits behind head on main.

Files Patch % Lines
...g/eclipse/edc/boot/system/runtime/BaseRuntime.java 90.47% 2 Missing ⚠️
...junit/extensions/DependencyInjectionExtension.java 0.00% 1 Missing ⚠️
...org/eclipse/edc/junit/extensions/EdcExtension.java 85.71% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4061      +/-   ##
==========================================
+ Coverage   71.74%   74.52%   +2.78%     
==========================================
  Files         919      976      +57     
  Lines       18457    19984    +1527     
  Branches     1037     1123      +86     
==========================================
+ Hits        13242    14894    +1652     
+ Misses       4756     4606     -150     
- Partials      459      484      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit 856165a into eclipse-edc:main Apr 2, 2024
16 checks passed
@ndr-brt ndr-brt deleted the 4060-base-runtime branch April 2, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solve little flaws in BaseRuntime
3 participants