refactor(iam): remove unused dummy-credentials-verifier #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliapampus
force-pushed
the
2094_remove_dummy_verifier
branch
from
8a80347
to
2b38d2b
Compare
paullatzelsperger
approved these changes
Oct 13, 2022
ndr-brt
approved these changes
Oct 14, 2022
|
@ndr-brt So this module is used as default impl right now? Then I will not remove it and rename it instead. |
|
No, is not provided by default, but I think we should "always" have a default implementation for every service (except maybe some more "crucial", as discussed in #2042 ), maybe this is something do be done in the future. TL;DR: let's get this merged :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Remove
:dummy-credentials-verifierWhy it does that
Not used anywhere in EDC repositories
Further notes
--
Linked Issue(s)
Closes #2094
Checklist
no-changelog)