Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: align/clean up module names and artifact IDs #2100

Merged

Conversation

juliapampus
Copy link
Contributor

@juliapampus juliapampus commented Oct 14, 2022

What this PR changes/adds

Implements the edc naming conventions

  • Aligns module names and artifactIds
  • Changes names if not uniquely identifiable within the project

See concrete changes in the commit history of this PR.

Why it does that

Refactoring

Further notes

Package restructuring will follow asap. Needs to build upon these changes.

Linked Issue(s)

Closes #2085

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@juliapampus juliapampus added the refactoring Cleaning up code and dependencies label Oct 14, 2022
@juliapampus juliapampus temporarily deployed to Azure-dev October 14, 2022 13:46 Inactive
@juliapampus juliapampus changed the title refactor(!): align/clean up module names and artifact IDs refactor!: align/clean up module names and artifact IDs Oct 14, 2022
@juliapampus juliapampus temporarily deployed to Azure-dev October 14, 2022 14:34 Inactive
extensions/README.md Show resolved Hide resolved
extensions/README.md Outdated Show resolved Hide resolved
@juliapampus juliapampus temporarily deployed to Azure-dev October 18, 2022 09:45 Inactive
@juliapampus juliapampus force-pushed the 2085_align_modules_artifacts branch 2 times, most recently from 532a8ce to 5aa8a80 Compare October 18, 2022 09:53
@juliapampus juliapampus temporarily deployed to Azure-dev October 18, 2022 09:54 Inactive
@juliapampus juliapampus temporarily deployed to Azure-dev October 18, 2022 11:35 Inactive
@juliapampus juliapampus temporarily deployed to Azure-dev October 18, 2022 11:39 Inactive
@juliapampus juliapampus temporarily deployed to Azure-dev October 18, 2022 11:48 Inactive
@juliapampus juliapampus temporarily deployed to Azure-dev October 18, 2022 11:52 Inactive
@juliapampus juliapampus temporarily deployed to Azure-dev October 18, 2022 12:45 Inactive
@juliapampus juliapampus temporarily deployed to Azure-dev October 18, 2022 13:03 Inactive
@juliapampus juliapampus temporarily deployed to Azure-dev October 18, 2022 13:53 Inactive
@juliapampus juliapampus temporarily deployed to Azure-dev October 18, 2022 14:06 Inactive
@juliapampus juliapampus merged commit 86344c8 into eclipse-edc:main Oct 18, 2022
@juliapampus juliapampus deleted the 2085_align_modules_artifacts branch October 18, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align artifactId and module names
4 participants