Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed all Federated Catalog modules #2214

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Nov 16, 2022

What this PR changes/adds

Removed all modules pertaining to the Federated Catalog feature.

Why it does that

The FederatedCatalog was relocated into its own repository and further development will happen there.

Further notes

  • re-added a missing dependency to generate Swagger UI (static HTML).
  • it is possible that, in the future, some components of the current FCC implementation will find their way back into the EDC core repo.

Linked Issue(s)

.

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

@codecov-commenter
Copy link

Codecov Report

Base: 64.54% // Head: 5.18% // Decreases project coverage by -59.35% ⚠️

Coverage data is based on head (38ce431) compared to base (a65b715).
Patch has no changes to coverable lines.

❗ Current head 38ce431 differs from pull request most recent head a5c9f08. Consider uploading reports for the commit a5c9f08 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #2214       +/-   ##
============================================
- Coverage     64.54%   5.18%   -59.36%     
- Complexity        0     167      +167     
============================================
  Files           843     814       -29     
  Lines         17587   17151      -436     
  Branches       1105    1088       -17     
============================================
- Hits          11352     890    -10462     
- Misses         5783   16197    +10414     
+ Partials        452      64      -388     
Impacted Files Coverage Δ
.../main/java/org/eclipse/edc/spi/result/Failure.java 0.00% <0.00%> (-100.00%) ⬇️
...main/java/org/eclipse/edc/spi/query/SortOrder.java 0.00% <0.00%> (-100.00%) ⬇️
...c/main/java/org/eclipse/edc/policy/model/Rule.java 0.00% <0.00%> (-100.00%) ⬇️
...n/java/org/eclipse/edc/spi/event/EventPayload.java 0.00% <0.00%> (-100.00%) ⬇️
...main/java/org/eclipse/edc/policy/model/Action.java 0.00% <0.00%> (-100.00%) ⬇️
.../src/main/java/org/eclipse/edc/sql/DoorKeeper.java 0.00% <0.00%> (-100.00%) ⬇️
...in/java/org/eclipse/edc/policy/model/Operator.java 0.00% <0.00%> (-100.00%) ⬇️
...org/eclipse/edc/util/stream/PartitionIterator.java 0.00% <0.00%> (-100.00%) ⬇️
...va/org/eclipse/edc/spi/observe/ObservableImpl.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/eclipse/edc/policy/model/Constraint.java 0.00% <0.00%> (-100.00%) ⬇️
... and 556 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paullatzelsperger paullatzelsperger added the refactoring Cleaning up code and dependencies label Nov 16, 2022
@paullatzelsperger paullatzelsperger temporarily deployed to Azure-dev November 16, 2022 16:39 Inactive
@paullatzelsperger paullatzelsperger merged commit b7932e5 into eclipse-edc:main Nov 21, 2022
@paullatzelsperger paullatzelsperger deleted the chore/remove_federated_catalog branch November 21, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core feature refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants