Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dsp catalog dispatcher): compact catalog request #2756

Merged
merged 2 commits into from
Apr 19, 2023
Merged

fix(dsp catalog dispatcher): compact catalog request #2756

merged 2 commits into from
Apr 19, 2023

Conversation

ronjaquensel
Copy link
Contributor

What this PR changes/adds

In the CatalogRequestHttpDelegate, compacts the catalog request JSON-LD structure when building a request. This includes setting the JSON-LD context.

Why it does that

When the catalog request is received, it is expected in the compacted form and compaction was previously missing.

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

@ronjaquensel ronjaquensel added bug Something isn't working dataspace-protocol related to the dataspace protocol labels Apr 18, 2023
@ronjaquensel ronjaquensel temporarily deployed to Azure-dev April 18, 2023 13:11 — with GitHub Actions Inactive
@juliapampus juliapampus changed the title fix(dsp-catalog-dispatcher): compact catalog request JSON-LD fix(dsp-catalog-dispatcher): compact catalog request Apr 18, 2023
@ronjaquensel ronjaquensel changed the title fix(dsp-catalog-dispatcher): compact catalog request fix(dsp catalog dispatcher): compact catalog request Apr 18, 2023
@ronjaquensel ronjaquensel temporarily deployed to Azure-dev April 19, 2023 14:27 — with GitHub Actions Inactive
@ronjaquensel ronjaquensel merged commit 65479dc into eclipse-edc:main Apr 19, 2023
@ronjaquensel ronjaquensel deleted the fix/compact-catalog-request-message branch April 19, 2023 14:51
majadlymhmd pushed a commit to FraunhoferISST/edc-connector that referenced this pull request May 10, 2023
@ronjaquensel @majadlymhmd
fix(dsp catalog dispatcher): compact catalog request (eclipse-edc#2756)
e493090
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmarino jimmarino jimmarino approved these changes

@juliapampus juliapampus juliapampus approved these changes

Assignees
No one assigned
Labels
bug Something isn't working dataspace-protocol related to the dataspace protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronjaquensel @jimmarino @juliapampus