Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move constants to :dsp-core #3027

Merged
merged 5 commits into from
May 17, 2023

Conversation

juliapampus
Copy link
Contributor

@juliapampus juliapampus commented May 17, 2023

What this PR changes/adds

Move constants to :dsp-core. Align naming to TYPE, PROPERTY, and VALUE.

Why it does that

Remove dependencies from dsp controllers on transformers.

Linked Issue(s)

Closes #3014

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

@juliapampus juliapampus temporarily deployed to Azure-dev May 17, 2023 07:11 — with GitHub Actions Inactive
@juliapampus juliapampus temporarily deployed to Azure-dev May 17, 2023 07:11 — with GitHub Actions Inactive
@juliapampus juliapampus temporarily deployed to Azure-dev May 17, 2023 07:17 — with GitHub Actions Inactive
@juliapampus juliapampus added enhancement New feature or request dataspace-protocol related to the dataspace protocol labels May 17, 2023
@juliapampus juliapampus temporarily deployed to Azure-dev May 17, 2023 07:31 — with GitHub Actions Inactive
@juliapampus juliapampus marked this pull request as ready for review May 17, 2023 07:35
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm feeling that the dsp-core could be called dsp-spi, because it contains just interface/basic types stuff, all good for the rest.

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -61.32 ⚠️

Comparison is base (b3e37dd) 66.10% compared to head (9145ff0) 4.79%.

❗ Current head 9145ff0 differs from pull request most recent head 4197035. Consider uploading reports for the commit 4197035 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #3027       +/-   ##
============================================
- Coverage     66.10%   4.79%   -61.32%     
- Complexity        0     225      +225     
============================================
  Files          1049    1049               
  Lines         21929   21929               
  Branches       1315    1315               
============================================
- Hits          14497    1052    -13445     
- Misses         6879   20816    +13937     
+ Partials        553      61      -492     
Impacted Files Coverage Δ
...atalog/api/controller/DspCatalogApiController.java 0.00% <0.00%> (-79.63%) ⬇️
...sonObjectFromCatalogRequestMessageTransformer.java 0.00% <0.00%> (-87.50%) ⬇️
.../JsonObjectToCatalogRequestMessageTransformer.java 0.00% <0.00%> (-75.00%) ⬇️
...on/api/controller/DspNegotiationApiController.java 0.00% <0.00%> (-96.84%) ⬇️
...ObjectFromContractAgreementMessageTransformer.java 0.00% <0.00%> (-100.00%) ⬇️
...ntractAgreementVerificationMessageTransformer.java 0.00% <0.00%> (-100.00%) ⬇️
...romContractNegotiationEventMessageTransformer.java 0.00% <0.00%> (-76.93%) ⬇️
...tractNegotiationTerminationMessageTransformer.java 0.00% <0.00%> (-100.00%) ⬇️
.../JsonObjectFromContractNegotiationTransformer.java 0.00% <0.00%> (-51.52%) ⬇️
...onObjectFromContractRequestMessageTransformer.java 0.00% <0.00%> (-92.86%) ⬇️
... and 15 more

... and 722 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@juliapampus juliapampus temporarily deployed to Azure-dev May 17, 2023 07:56 — with GitHub Actions Inactive
@juliapampus juliapampus temporarily deployed to Azure-dev May 17, 2023 08:09 — with GitHub Actions Inactive
@ndr-brt ndr-brt merged commit 6ef51ac into eclipse-edc:main May 17, 2023
@juliapampus juliapampus deleted the refactor/3014_constants branch May 17, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataspace-protocol related to the dataspace protocol enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: move DSP constants to :dsp-core
3 participants