-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move constants to :dsp-core #3027
refactor: move constants to :dsp-core #3027
Conversation
ee3e6d3
to
3eb88c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm feeling that the dsp-core
could be called dsp-spi
, because it contains just interface/basic types stuff, all good for the rest.
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #3027 +/- ##
============================================
- Coverage 66.10% 4.79% -61.32%
- Complexity 0 225 +225
============================================
Files 1049 1049
Lines 21929 21929
Branches 1315 1315
============================================
- Hits 14497 1052 -13445
- Misses 6879 20816 +13937
+ Partials 553 61 -492
☔ View full report in Codecov by Sentry. |
What this PR changes/adds
Move constants to
:dsp-core
. Align naming toTYPE
,PROPERTY
, andVALUE
.Why it does that
Remove dependencies from dsp controllers on transformers.
Linked Issue(s)
Closes #3014
Checklist
no-changelog
)