feat(dsp): implement GET /id negotiation endpoint #3212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronjaquensel
added
enhancement
jimmarino
approved these changes
Jun 22, 2023
ndr-brt
reviewed
Jun 23, 2023
| private ServiceResult<ContractNegotiation> validateGetRequest(ClaimToken claimToken, String id, ContractNegotiation negotiation) { | ||
| var result = validationService.validateRequest(claimToken, negotiation); | ||
| if (result.failed()) { | ||
| // should return not found if counter-party not authorized |
There was a problem hiding this comment.
I know that this is stated in the specs, but shouldn't be more http-like to return 403?
There was a problem hiding this comment.
I think the idea behind returning the 404 is to not give out information about the existence of processes to unauthorized parties.
...clipse/edc/connector/service/contractnegotiation/ContractNegotiationProtocolServiceImpl.java
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #3212 +/- ##
=======================================
Coverage 65.60% 65.60%
=======================================
Files 844 844
Lines 16902 16914 +12
Branches 931 933 +2
=======================================
+ Hits 11089 11097 +8
- Misses 5441 5444 +3
- Partials 372 373 +1
☔ View full report in Codecov by Sentry. |
ndr-brt
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds a method
findByIdto theContractNegotiationProtocolService, that takes aClaimTokenas parameter and returns a negotiation only if the requesting party is authorized. Using this method, implements theGET /idendpoint in theDspNegotiationApiController.Why it does that
To support the protocol specification
Linked Issue(s)
Closes #2795