feat(IATP): configurable trusted issuers #3603
Conversation
wolf4ood
force-pushed
the
feat/3602_configurable_trusted_issuers
branch
2 times, most recently
from
6ab7ba8
to
999b855
Compare
wolf4ood
force-pushed
the
feat/3602_configurable_trusted_issuers
branch
from
999b855
to
f5cefb1
Compare
| @@ -0,0 +1,13 @@ | |||
| # Trusted Issuer Configuration Extension | |||
There was a problem hiding this comment.
Can we get rid of this documentation and just use the annotations for this?
There was a problem hiding this comment.
Do we support the prefix style in annotations?
| var config = context.getConfig(CONFIG_PREFIX); | ||
| var issuers = config.partition().map(this::configureIssuer).toList(); | ||
| if (issuers.isEmpty()) { | ||
| throw new EdcException("The list of trusted issuers is empty"); |
There was a problem hiding this comment.
Should this abort the runtime or just issue an error?
There was a problem hiding this comment.
I though of just issuing an error message but then in theory it will not work anyway at runtime since the list is empty
There was a problem hiding this comment.
Yeah, I thought though it may be "nicer" to not abort, but don't have a strong opinion.
extensions/common/iam/identity-trust/identity-trust-issuers-configuration/build.gradle.kts
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3603 +/- ##
==========================================
- Coverage 72.10% 72.08% -0.03%
==========================================
Files 897 899 +2
Lines 17919 17984 +65
Branches 1018 1023 +5
==========================================
+ Hits 12920 12963 +43
- Misses 4562 4580 +18
- Partials 437 441 +4 ☔ View full report in Codecov by Sentry. |
| private Issuer configureIssuer(Config config) { | ||
|
|
||
| var id = config.getString(ID_SUFFIX); | ||
| var propertiesConfig = config.getString(PROPERTIES_SUFFIX, "{}"); |
There was a problem hiding this comment.
alternatively, pass null as default value, and instantiate Issuer(id, Map.or()) if the propertiesConfig is null. saves us a call to the typemanager and makes the code a bit more explicit.
* feat(IATP): configurable trusted issuers * pr remarks
What this PR changes/adds
Adds an extension for configuring the list of trusted issuer in the
TrustedIssuerRegistryWhy it does that
iatp adoption
Linked Issue(s)
Closes #3602