Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make VP request to CredentialService #3618

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Nov 16, 2023

What this PR changes/adds

This PR adds the DefaultCredentialServiceClient, which is used to make VP requests against a CredentialService to obtain VPs.

In addition, this PR adds a JwtToVerifiableCredentialTransformer and a JwtToVerifiablePresentationTransformer, as they didn't exist up until now.

Why it does that

IATP implementation

Further notes

  • Currently, sending DIF Presentation Definitions is not yet supported. So we need to parse whatever is coming back from the CS.

Linked Issue(s)

Closes #3495

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger marked this pull request as draft November 16, 2023 09:41
@paullatzelsperger paullatzelsperger marked this pull request as ready for review November 17, 2023 15:17
Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (1a92799) 71.74% compared to head (964f088) 71.83%.
Report is 5 commits behind head on main.

Files Patch % Lines
.../core/defaults/DefaultCredentialServiceClient.java 83.01% 5 Missing and 4 partials ⚠️
...sform/to/JwtToVerifiableCredentialTransformer.java 76.92% 7 Missing and 2 partials ⚠️
...orm/to/JwtToVerifiablePresentationTransformer.java 86.48% 4 Missing and 1 partial ⚠️
...identitytrust/IdentityTrustTransformExtension.java 0.00% 4 Missing ⚠️
...om/JsonObjectFromPresentationQueryTransformer.java 0.00% 3 Missing ⚠️
.../identitytrust/core/IdentityAndTrustExtension.java 0.00% 2 Missing ⚠️
.../model/credentialservice/PresentationResponse.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3618      +/-   ##
==========================================
+ Coverage   71.74%   71.83%   +0.09%     
==========================================
  Files         909      913       +4     
  Lines       18084    18267     +183     
  Branches     1021     1039      +18     
==========================================
+ Hits        12975    13123     +148     
- Misses       4666     4694      +28     
- Partials      443      450       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger merged commit 7810c30 into eclipse-edc:main Nov 20, 2023
17 checks passed
@paullatzelsperger paullatzelsperger deleted the feat/3495_obtain_vp_from_credentialservice branch November 20, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IATP: IdentityAndTrustService obtain VP from CredentialService
3 participants