Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce configuration f. SignalinAPI #3938

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

This PR introduces a configuration module for the Signaling API and it adds it and the data-plane-signaling-api module into a subdirectory.

Why it does that

For some time the SignalingAPI will have to coexist with the ControlAPI, and we must be able to register resources like JSON-LD interceptors,
authentication mechanisms, mappers, etc. separately.

Further notes

.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added refactoring Cleaning up code and dependencies api Feature related to the (REST) api dpf Feature related to the Data Plane Framework labels Feb 29, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 84.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 73.15%. Comparing base (7f20ba5) to head (efcc243).
Report is 106 commits behind head on main.

Files Patch % Lines
...aling/configuration/SignalingApiConfiguration.java 62.50% 3 Missing ⚠️
...figuration/SignalingApiConfigurationExtension.java 94.11% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3938      +/-   ##
==========================================
+ Coverage   71.74%   73.15%   +1.41%     
==========================================
  Files         919      939      +20     
  Lines       18457    18908     +451     
  Branches     1037     1073      +36     
==========================================
+ Hits        13242    13833     +591     
+ Misses       4756     4616     -140     
  Partials      459      459              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger force-pushed the feat/introduce_signalingapi_configuration branch from efcc243 to dd66976 Compare February 29, 2024 13:02
@paullatzelsperger paullatzelsperger merged commit 4ec736b into eclipse-edc:main Feb 29, 2024
17 checks passed
@paullatzelsperger paullatzelsperger deleted the feat/introduce_signalingapi_configuration branch February 29, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Feature related to the (REST) api dpf Feature related to the Data Plane Framework refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants