feat: add STS Accounts API #4493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * @param parameters Optional generator arguments, such as a salt value | ||
| * @return a randomly generated client secret. | ||
| */ | ||
| String generateClientSecret(@Nullable Object parameters); |
Check notice
Code scanning / CodeQL
Useless parameter Note
.../main/java/org/eclipse/edc/iam/identitytrust/sts/spi/service/StsTokenGenerationProvider.java
Fixed
Show fixed
Hide fixed
ndr-brt
reviewed
Sep 26, 2024
.../org/eclipse/edc/api/iam/identitytrust/sts/accounts/controller/StsAccountsApiController.java
Outdated
Show resolved
Hide resolved
...y-trust-sts/identity-trust-sts-accounts-api/src/main/resources/sts-accounts-api-version.json
Outdated
Show resolved
Hide resolved
...y-trust-sts/identity-trust-sts-accounts-api/src/main/resources/sts-accounts-api-version.json
Show resolved
Hide resolved
wolf4ood
approved these changes
Sep 26, 2024
...ccounts-api/src/main/resources/META-INF/services/org.eclipse.edc.spi.system.ServiceExtension
Outdated
Show resolved
Hide resolved
...ql/src/main/java/org/eclipse/edc/iam/identitytrust/sts/store/SqlStsClientStoreExtension.java
Outdated
Show resolved
Hide resolved
.../main/java/org/eclipse/edc/iam/identitytrust/sts/spi/service/StsTokenGenerationProvider.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Enrico Risa <enrico.risa@gmail.com>
.../main/java/org/eclipse/edc/iam/identitytrust/sts/spi/service/StsTokenGenerationProvider.java
Fixed
Show fixed
Hide fixed
| * @return The {@link TokenGenerationService} | ||
| */ | ||
| TokenGenerationService tokenGeneratorFor(StsClient client); | ||
| TokenGenerationService tokenGeneratorFor(StsAccount stsAccount); |
Check notice
Code scanning / CodeQL
Useless parameter Note
ndr-brt
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
adds the STS Accounts API (+controller) to manage STS Accounts (formerly known as StsClients). To achieve that, the
StsAccountServicewas extended to accommodate the new functionality like updating, deleting etc.Why it does that
a way to manage STS Accounts is required
Further notes
StsClient...->StsAccount...AuthenticationServicefor the"sts-accounts-api"contextLinked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.