o.e.jdt.ls.repository should publish all dependencies. #3300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber
force-pushed
the
all-deps-in-repo
branch
from
9b58fd2
to
870c805
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make the repository published under https://download.eclipse.org/jdtls/snapshots/repository/latest/ contain all dependencies, and source bundles.
I tried combining this with the org.eclipse.jdt.ls.product module but the product and repository have separate requirements that are difficult to satisfy in a single module.
Ther repository module needs to include all dependencies including source bundles, and test dependencies. While we can easily exclude source bundles from the product, excluding the test dependencies gets tricky and the exclusion list would need to be updated for every new dependency needing to be excluded. It's easier to just keep these two modules separate.