feat(nm): implementation of IPv6 configuration #4786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tIp6' method Signed-off-by: SimoneFiorani <simone.fiorani@abinsula.com>
Signed-off-by: SimoneFiorani <simone.fiorani@abinsula.com>
Signed-off-by: SimoneFiorani <simone.fiorani@abinsula.com>
Signed-off-by: SimoneFiorani <simone.fiorani@abinsula.com>
|
@sfiorani You have a couple of test failures probably due to a missing Set |
mattdibi
reviewed
Jul 26, 2023
kura/org.eclipse.kura.nm/src/main/java/org/eclipse/kura/nm/KuraIp6AddressGenerationMode.java
Outdated
Show resolved
Hide resolved
mattdibi
reviewed
Jul 26, 2023
kura/org.eclipse.kura.nm/src/main/java/org/eclipse/kura/nm/KuraIp6Privacy.java
Outdated
Show resolved
Hide resolved
mattdibi
reviewed
Jul 26, 2023
kura/org.eclipse.kura.nm/src/main/java/org/eclipse/kura/nm/KuraIp6ConfigurationMethod.java
Outdated
Show resolved
Hide resolved
mattdibi
reviewed
Jul 26, 2023
...org.eclipse.kura.nm/src/main/java/org/eclipse/kura/nm/configuration/NMSettingsConverter.java
Outdated
Show resolved
Hide resolved
mattdibi
reviewed
Jul 26, 2023
...org.eclipse.kura.nm/src/main/java/org/eclipse/kura/nm/configuration/NMSettingsConverter.java
Outdated
Show resolved
Hide resolved
Signed-off-by: SimoneFiorani <simone.fiorani@abinsula.com>
mattdibi
reviewed
Jul 26, 2023
kura/test/org.eclipse.kura.nm.test/src/test/java/org/eclipse/kura/nm/NMDbusConnectorTest.java
Outdated
Show resolved
Hide resolved
mattdibi
reviewed
Jul 27, 2023
...org.eclipse.kura.nm/src/main/java/org/eclipse/kura/nm/configuration/NMSettingsConverter.java
Outdated
Show resolved
Hide resolved
|
Please check and solve the two issues reported by Sonar: https://sonarcloud.io/project/issues?resolved=false&severities=CRITICAL&sinceLeakPeriod=true&branch=PR-4786&id=org.eclipse.kura%3Akura |
mattdibi
reviewed
Jul 27, 2023
...org.eclipse.kura.nm/src/main/java/org/eclipse/kura/nm/configuration/NMSettingsConverter.java
Outdated
Show resolved
Hide resolved
mattdibi
reviewed
Jul 27, 2023
...se.kura.nm.test/src/test/java/org/eclipse/kura/nm/configuration/NMSettingsConverterTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: SimoneFiorani <simone.fiorani@abinsula.com>
mattdibi
reviewed
Jul 27, 2023
...org.eclipse.kura.nm/src/main/java/org/eclipse/kura/nm/configuration/NMSettingsConverter.java
Outdated
Show resolved
Hide resolved
mattdibi
reviewed
Jul 27, 2023
...org.eclipse.kura.nm/src/main/java/org/eclipse/kura/nm/configuration/NMSettingsConverter.java
Outdated
Show resolved
Hide resolved
mattdibi
reviewed
Jul 27, 2023
kura/org.eclipse.kura.nm/src/main/java/org/eclipse/kura/nm/KuraIp6AddressGenerationMode.java
Show resolved
Hide resolved
mattdibi
reviewed
Jul 27, 2023
kura/org.eclipse.kura.nm/src/main/java/org/eclipse/kura/nm/KuraIp6Privacy.java
Show resolved
Hide resolved
mattdibi
reviewed
Jul 27, 2023
...g.eclipse.kura.nm/src/main/java/org/eclipse/kura/nm/enums/NMSettingIP6ConfigAddrGenMode.java
Show resolved
Hide resolved
mattdibi
reviewed
Jul 27, 2023
kura/org.eclipse.kura.nm/src/main/java/org/eclipse/kura/nm/enums/NMSettingIP6ConfigPrivacy.java
Show resolved
Hide resolved
mattdibi
reviewed
Jul 27, 2023
...se.kura.nm.test/src/test/java/org/eclipse/kura/nm/configuration/NMSettingsConverterTest.java
Outdated
Show resolved
Hide resolved
mattdibi
reviewed
Jul 27, 2023
...se.kura.nm.test/src/test/java/org/eclipse/kura/nm/configuration/NMSettingsConverterTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: SimoneFiorani <simone.fiorani@abinsula.com>
Signed-off-by: SimoneFiorani <simone.fiorani@abinsula.com>
mattdibi
reviewed
Jul 27, 2023
kura/org.eclipse.kura.nm/src/main/java/org/eclipse/kura/nm/KuraIp6Privacy.java
Outdated
Show resolved
Hide resolved
|
@sfiorani the only missing thing at this point are the unit tests. The production code is 👌 |
mattdibi
approved these changes
Jul 27, 2023
|
Opened IP review: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/9819 |
|
IP check successful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the configuration of IPv6 protocol in the NetworkManager bundle.
New enums to map NM settings and Snapshots settings in Kura
NMSettingIP6ConfigAddrGenModeandNMSettingIP6ConfigPrivacyenums to map theaddr-gen-modeandip6-privacyNetworkManager's settingsKuraIp6ConfigurationMethodandKuraIp6Privacyenums that maps Snapshots' values for previous NM's settingsKuraIp6ConfigurationMethodto map NetworkManager's settingmethodfor IPv6 protocolIPv6 protocol configuration
In
org.eclipse.kura.nm.configuration.NMSettingsConverter, thebuildIpv6Settingsmethod is now implemented: the IPv6 configuration can be set according to NetworkManager requirements.Related Issue: This PR fixes/closes {issue number}
Description of the solution adopted: A more detailed description of the changes made to solve/close one or more issues. If the PR is simple and easy to understand this section can be skipped
Screenshots: If applicable, add screenshots to help explain your solution
Manual Tests: Optional description of the tests performed to check correct functioning of changes, useful for an efficient review
Any side note on the changes made: Description of any other change that has been made, which is not directly linked to the issue resolution [e.g. Code clean up/Sonar issue resolution]