Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web2): add IPv6 configuration tab #4800

Merged

Conversation

marcellorinaldo
Copy link
Contributor

@marcellorinaldo marcellorinaldo commented Aug 9, 2023

This PR adds a net tab "IPv6" to the networking section that allows to configure IPv6-related settings.

Related Issue: N/A.

Description of the solution adopted: Summary of changes:

  • Added UI tab
  • Added validations
  • Refactor of the network tabs orcherstrator code
  • Backend code not implemented in this PR, will be separate

Screenshots:

Screenshot 2023-08-10 at 12 08 29

Manual Tests:

  • Address Generation Mode and Privacy are enabled only when Configure = SLAAC
  • When Status = Enabled for LAN and Configure = Manually then only IP address and Subnet Mask are editable.
  • When Status = Enabled for WAN and Configure = Manually then WAN Priority, IP address, Subnet Mask, Gateway, and DNS Servers are editable.
  • When Status = Enabled for WAN and Configure != Manually the DNS Servers is editable
  • WAN Priority is enabled only when Status = Enabled for WAN
  • All fields are disabled when Status = Disabled or a Loopback interface is selected
  • Tabs order (IPv4, IPv6, Wireless, DHCPv4&NAT, Modem, etc.) is the same as prior this PR
  • WAN Priority accepts only integers > -1
  • Subnet mask accepts only integers between 1 and 128
  • Fields that accept IPv6 addresses have working validation, even with shortened addresses. Some test cases can be found below
  • IPv6 tab is shown only on generic profiles
  • Information hints are correctly shown when hovering over the enabled elements

IPv6 addresses (positive) test cases:

  • 2001:0000:3238:DFE1:0063:0000:0000:FEFB
  • 2001:0000:3238:DFE1:63:0000:0000:FEFB
  • 2001:0000:3238:DFE1:63::FEFB
  • 2001:0:3238:DFE1:63::FEFB
  • ::
  • ::1
  • FE80::

Any side note on the changes made: N/A.

…adding/removing tabs in navbar

Signed-off-by: Marcello Martina <martina.marcello.rinaldo@outlook.com>
Signed-off-by: Marcello Martina <martina.marcello.rinaldo@outlook.com>
Signed-off-by: Marcello Martina <martina.marcello.rinaldo@outlook.com>
Signed-off-by: Marcello Martina <martina.marcello.rinaldo@outlook.com>
Signed-off-by: Marcello Martina <martina.marcello.rinaldo@outlook.com>
Signed-off-by: Marcello Martina <martina.marcello.rinaldo@outlook.com>
Signed-off-by: Marcello Martina <martina.marcello.rinaldo@outlook.com>
…ts, added IPv6-related message resources

Signed-off-by: Marcello Martina <martina.marcello.rinaldo@outlook.com>
Signed-off-by: Marcello Martina <martina.marcello.rinaldo@outlook.com>
Signed-off-by: Marcello Martina <martina.marcello.rinaldo@outlook.com>
Signed-off-by: Marcello Martina <martina.marcello.rinaldo@outlook.com>
Signed-off-by: Marcello Martina <martina.marcello.rinaldo@outlook.com>
…r LAN

Signed-off-by: Marcello Martina <martina.marcello.rinaldo@outlook.com>
…re update

Signed-off-by: Marcello Martina <martina.marcello.rinaldo@outlook.com>
Signed-off-by: Marcello Martina <martina.marcello.rinaldo@outlook.com>
@marcellorinaldo marcellorinaldo marked this pull request as ready for review August 10, 2023 10:13
Signed-off-by: Marcello Martina <martina.marcello.rinaldo@outlook.com>
Signed-off-by: Marcello Martina <martina.marcello.rinaldo@outlook.com>
Signed-off-by: Marcello Martina <martina.marcello.rinaldo@outlook.com>
@sfiorani
Copy link
Contributor

Tested on Raspberry Pi, with generic-aarch64 generic profile: everything is ok

@pierantoniomerlino pierantoniomerlino merged commit 8566aa9 into eclipse-kura:develop Aug 11, 2023
1 check passed
@pierantoniomerlino pierantoniomerlino deleted the feat/web2/add-ipv6-tab branch August 11, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants