-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add front end support for WPA Enterprise #4852
feat: add front end support for WPA Enterprise #4852
Conversation
kura/org.eclipse.kura.web2/src/main/java/org/eclipse/kura/web/shared/model/Gwt8021xConfig.java
Outdated
Show resolved
Hide resolved
kura/org.eclipse.kura.web2/src/main/java/org/eclipse/kura/web/shared/model/Gwt8021xEap.java
Outdated
Show resolved
Hide resolved
...g.eclipse.kura.web2/src/main/java/org/eclipse/kura/web/server/net/GwtNetworkServiceImpl.java
Show resolved
Hide resolved
kura/org.eclipse.kura.web2/src/main/java/org/eclipse/kura/web/client/ui/network/Tab8021xUi.java
Outdated
Show resolved
Hide resolved
5033589
to
3e8549a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this configuration:
- Enterprise EAP = any value TLS/TTLS/PEAP
- Inner Authentication = NONE
- Identity = test
- Password = hellotesttest
I get the following stacktrace:
2023-09-14T09:58:09,736 [ConfigurationListener Event Queue] ERROR o.e.k.n.NMDbusConnector - Unable to apply configuration to the device path /org/freedesktop/NetworkManager/Devices/3
java.util.NoSuchElementException: The "net.interface.wlan0.config.802-1x.client-cert" key is missing.
at org.eclipse.kura.nm.NetworkProperties.get(NetworkProperties.java:41)
at org.eclipse.kura.nm.configuration.NMSettingsConverter.create8021xTls(NMSettingsConverter.java:169)
at org.eclipse.kura.nm.configuration.NMSettingsConverter.build8021xSettings(NMSettingsConverter.java:126)
at org.eclipse.kura.nm.configuration.NMSettingsConverter.buildSettings(NMSettingsConverter.java:97)
at org.eclipse.kura.nm.NMDbusConnector.enableInterface(NMDbusConnector.java:443)
at org.eclipse.kura.nm.NMDbusConnector.manageConfiguredInterface(NMDbusConnector.java:422)
at org.eclipse.kura.nm.NMDbusConnector.doApply(NMDbusConnector.java:381)
at org.eclipse.kura.nm.NMDbusConnector.lambda$0(NMDbusConnector.java:366)
at java.util.ArrayList.forEach(ArrayList.java:1259)
at org.eclipse.kura.nm.NMDbusConnector.doApply(NMDbusConnector.java:363)
at org.eclipse.kura.nm.NMDbusConnector.apply(NMDbusConnector.java:322)
at org.eclipse.kura.nm.configuration.NMConfigurationServiceImpl.writeNetworkConfigurationSettings(NMConfigurationServiceImpl.java:317)
at org.eclipse.kura.nm.configuration.NMConfigurationServiceImpl.update(NMConfigurationServiceImpl.java:218)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.felix.scr.impl.inject.methods.BaseMethod.invokeMethod(BaseMethod.java:228)
at org.apache.felix.scr.impl.inject.methods.BaseMethod.access$500(BaseMethod.java:41)
at org.apache.felix.scr.impl.inject.methods.BaseMethod$Resolved.invoke(BaseMethod.java:664)
at org.apache.felix.scr.impl.inject.methods.BaseMethod.invoke(BaseMethod.java:510)
at org.apache.felix.scr.impl.inject.methods.ActivateMethod.invoke(ActivateMethod.java:317)
at org.apache.felix.scr.impl.inject.methods.ActivateMethod.invoke(ActivateMethod.java:307)
at org.apache.felix.scr.impl.manager.SingleComponentManager.invokeModifiedMethod(SingleComponentManager.java:836)
at org.apache.felix.scr.impl.manager.SingleComponentManager.modify(SingleComponentManager.java:791)
at org.apache.felix.scr.impl.manager.SingleComponentManager.reconfigure(SingleComponentManager.java:709)
at org.apache.felix.scr.impl.manager.SingleComponentManager.reconfigure(SingleComponentManager.java:673)
at org.apache.felix.scr.impl.manager.ConfigurableComponentHolder.configurationUpdated(ConfigurableComponentHolder.java:435)
at org.apache.felix.scr.impl.manager.RegionConfigurationSupport.configurationEvent(RegionConfigurationSupport.java:316)
at org.apache.felix.scr.impl.manager.RegionConfigurationSupport$2.configurationEvent(RegionConfigurationSupport.java:118)
at org.eclipse.equinox.internal.cm.EventDispatcher$1.run(EventDispatcher.java:92)
at org.eclipse.equinox.internal.cm.SerializedTaskQueue$1.run(SerializedTaskQueue.java:40)
Maybe such combination is not allowed? If not allowed, we should prevent the user from setting it by disabling some fields.
Setting Inner Authentication to MSCHAPv2
does not cause issues.
kura/org.eclipse.kura.web2/src/main/java/org/eclipse/kura/web/client/ui/network/Tab8021xUi.java
Outdated
Show resolved
Hide resolved
@marcellorinaldo The new commits add the following validation |
64cb601
to
3ec6c9b
Compare
* feat: add front end support for WPA Enterprise * fix: constrain net.wifi version * fix: copyright header * fix: copyright header * fix: copyright header * refactor: removed char * feat: conditionally enable and disable UI elements * feat: added password validation * fix: hid check password button
* feat: add front end support for WPA Enterprise * fix: constrain net.wifi version * fix: copyright header * fix: copyright header * fix: copyright header * refactor: removed char * feat: conditionally enable and disable UI elements * feat: added password validation * fix: hid check password button
Brief description of the PR. [e.g. Added
null
check onobject
to avoidNullPointerException
]Related Issue: This PR fixes/closes {issue number}
Description of the solution adopted: A more detailed description of the changes made to solve/close one or more issues. If the PR is simple and easy to understand this section can be skipped
Screenshots: If applicable, add screenshots to help explain your solution
Manual Tests: Optional description of the tests performed to check correct functioning of changes, useful for an efficient review
Any side note on the changes made: Description of any other change that has been made, which is not directly linked to the issue resolution [e.g. Code clean up/Sonar issue resolution]