Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added session management support for REST service #4855

Merged
merged 6 commits into from
Sep 19, 2023

Conversation

nicolatimeus
Copy link
Contributor

Note: We are using the Conventional Commits convention for our pull request titles. Please take a look at the PR title format document for the supported types and scopes.

Brief description of the PR. [e.g. Added null check on object to avoid NullPointerException]

Related Issue: This PR fixes/closes {issue number}

Description of the solution adopted: A more detailed description of the changes made to solve/close one or more issues. If the PR is simple and easy to understand this section can be skipped

  • Adds session management, the new session/v1 rest endpoints can be used to create a session.
  • The existing BASIC and certificate authentication mechanisms are still available, but can be disable with dedicated RestService configuration options.
  • Adds a new UserAdminHelper helper class for interacting with the UserAdmin.
  • Introduces a workaround for a OSGI JAX-RS connector issue that makes impossible to create http sessions, the workaround will likely be removed in the future.

Screenshots: If applicable, add screenshots to help explain your solution

Manual Tests: Optional description of the tests performed to check correct functioning of changes, useful for an efficient review

Any side note on the changes made: Description of any other change that has been made, which is not directly linked to the issue resolution [e.g. Code clean up/Sonar issue resolution]

Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com>
Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com>
@nicolatimeus
Copy link
Contributor Author

@MMaiero
Copy link
Contributor

MMaiero commented Sep 19, 2023

Comment applied it is a false positive in Sonar.
Now that the item is solved the quality gate is green and the code can be merged.

@MMaiero MMaiero merged commit 7edaa6d into eclipse-kura:develop Sep 19, 2023
2 of 3 checks passed
pierantoniomerlino pushed a commit that referenced this pull request Sep 26, 2023
* feat: Added session management support for REST service

Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com>

* fix: Fixed incorrect endpoint paths in metatype

Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com>

* fix: Added minimum value for session inactivity interval

* fix: Removed unused method

Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com>

* fix: Fixed spelling error

* fix: Do not return XSRF token for expired session

Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com>

---------

Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com>
GregoryIvo pushed a commit to GregoryIvo/kura that referenced this pull request Sep 28, 2023
…#4855)

* feat: Added session management support for REST service

Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com>

* fix: Fixed incorrect endpoint paths in metatype

Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com>

* fix: Added minimum value for session inactivity interval

* fix: Removed unused method

Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com>

* fix: Fixed spelling error

* fix: Do not return XSRF token for expired session

Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com>

---------

Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com>
@nicolatimeus nicolatimeus deleted the feat_rest-auth branch March 22, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants