-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added session management support for REST service #4855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com>
Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com>
Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com>
salvatore-coppola
approved these changes
Sep 14, 2023
Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com>
Build is failing due to this wierd sonarlint issue: https://sonarcloud.io/project/issues?resolved=false&severities=BLOCKER&sinceLeakPeriod=true&branch=PR-4855&id=org.eclipse.kura%3Akura&open=AYqO1XF26np3lwpGkziw. False positive? |
Comment applied it is a false positive in Sonar. |
pierantoniomerlino
pushed a commit
that referenced
this pull request
Sep 26, 2023
* feat: Added session management support for REST service Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com> * fix: Fixed incorrect endpoint paths in metatype Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com> * fix: Added minimum value for session inactivity interval * fix: Removed unused method Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com> * fix: Fixed spelling error * fix: Do not return XSRF token for expired session Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com> --------- Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com>
GregoryIvo
pushed a commit
to GregoryIvo/kura
that referenced
this pull request
Sep 28, 2023
…#4855) * feat: Added session management support for REST service Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com> * fix: Fixed incorrect endpoint paths in metatype Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com> * fix: Added minimum value for session inactivity interval * fix: Removed unused method Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com> * fix: Fixed spelling error * fix: Do not return XSRF token for expired session Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com> --------- Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com>
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the PR. [e.g. Added
null
check onobject
to avoidNullPointerException
]Related Issue: This PR fixes/closes {issue number}
Description of the solution adopted: A more detailed description of the changes made to solve/close one or more issues. If the PR is simple and easy to understand this section can be skipped
session/v1
rest endpoints can be used to create a session.RestService
configuration options.UserAdminHelper
helper class for interacting with theUserAdmin
.Screenshots: If applicable, add screenshots to help explain your solution
Manual Tests: Optional description of the tests performed to check correct functioning of changes, useful for an efficient review
Any side note on the changes made: Description of any other change that has been made, which is not directly linked to the issue resolution [e.g. Code clean up/Sonar issue resolution]