fix(net.admin): Fix ipv6 threat manager #4864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com>
Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com>
MMaiero
approved these changes
Sep 25, 2023
pierantoniomerlino
added a commit
that referenced
this pull request
Sep 26, 2023
* Added FirewallConfigurationServiceIPv6 to old net.admin bundle Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com> * Added missing file Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com> --------- Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com>
GregoryIvo
pushed a commit
to GregoryIvo/kura
that referenced
this pull request
Sep 28, 2023
* Added FirewallConfigurationServiceIPv6 to old net.admin bundle Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com> * Added missing file Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com> --------- Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com>
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
FirewallConfigurationServiceIPv6class to thenet.adminbundle. In this way, thenetwork.threat.managercan import the class and don't throw any exception at the activation. The service, however, is not exported, since thenet.admindoesn't support IPv6.