fix(nm): Fixed dnsmasq behavior on configuration change #5295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com>
|
@sfiorani could you please check again the AP with generic profiles? |
Tested on Raspberry Pi 5 with Kura generic aarch64 and everything seems to work. I tried different combinations of Security and Cipher. |
MMaiero
approved these changes
Jun 27, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
Changed operations order in dhcp server configuration Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com> (cherry picked from commit e5737bd)
MMaiero
pushed a commit
that referenced
this pull request
Jun 28, 2024
…ease-5.5.0] (#5301) fix(nm): Fixed dnsmasq behavior on configuration change (#5295) Changed operations order in dhcp server configuration Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com> (cherry picked from commit e5737bd) Co-authored-by: Pierantonio Merlino <pierantonio.merlino@eurotech.com>
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a weird behaviour when
dnsmasqis used as DHCP server with generic profiles and NM.Related Issue: This PR fixes/closes N/A
Description of the solution adopted: During testing we found that the
dnsmasqused as DHCP server doesn't listen on port 67 after a re-configuration. If the configuration was submitted again, the service starts working as aspected.After further investigations, we found that when the problem occours, the dnsmasq configuration file is not present in the filesystem. So, the service is running, but without any configuration of the given interface. As a consequence, the port 67 UDP is not used.
This is due to a wrong operation sequence during the DHCP server startup performed by Kura. The configuration file is written, but when the DHCP server activation is triggered, the code disable the service and then re-enable it. During the disable, the configuration file is removed. If a new configuration is submitted again, all works since the bundle doesn’t recognize the service as running and doesn’t disable it.
This PR fixes the issue changing the order of the operation when the DHCP server is configured. Now, the
dnsmasqservice is disable before that the configuration file is written.Manual Tests: Using a generic profile, configure an AP with DHCP server enabled. Try to connect to the configured AP with another device (i.e. a laptop) and try to get an IP address. Change the AP configuration and apply it. Then try to connect again with the laptop. The laptop should be able to connect and get the address.