feat: removed dial string and pdp from modem UI #5354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MMaiero
force-pushed
the
feat_remove-modem-dial-pdp
branch
from
f20ed9b
to
87b8f7c
Compare
| @@ -22,8 +22,6 @@ | |||
| import org.eclipse.kura.web.client.util.MessageUtils; | |||
| import org.eclipse.kura.web.shared.model.GwtModemAuthType; | |||
| import org.eclipse.kura.web.shared.model.GwtModemInterfaceConfig; | |||
| import org.eclipse.kura.web.shared.model.GwtModemPdpEntry; | |||
| import org.eclipse.kura.web.shared.model.GwtModemPdpType; | |||
There was a problem hiding this comment.
Could we delete also these classes? Are they used somewhere?
pierantoniomerlino
previously approved these changes
Sep 13, 2024
MMaiero
force-pushed
the
feat_remove-modem-dial-pdp
branch
from
9dd4bdf
to
e62375e
Compare
pierantoniomerlino
previously approved these changes
Sep 23, 2024
|
@MMaiero Please update the copyright headers. |
MMaiero
force-pushed
the
feat_remove-modem-dial-pdp
branch
from
757e507
to
daf62c5
Compare
Signed-off-by: MMaiero <matteo.maiero@eurotech.com>
Signed-off-by: MMaiero <matteo.maiero@eurotech.com>
Signed-off-by: MMaiero <matteo.maiero@eurotech.com>
Signed-off-by: MMaiero <matteo.maiero@eurotech.com>
MMaiero
force-pushed
the
feat_remove-modem-dial-pdp
branch
from
daf62c5
to
e684825
Compare
|
@MMaiero the |
Signed-off-by: MMaiero <matteo.maiero@eurotech.com>
Done |
pierantoniomerlino
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the PR. [e.g. Added
nullcheck onobjectto avoidNullPointerException]Related Issue: This PR fixes/closes {issue number}
Description of the solution adopted: A more detailed description of the changes made to solve/close one or more issues. If the PR is simple and easy to understand this section can be skipped
Screenshots: If applicable, add screenshots to help explain your solution
Manual Tests: Optional description of the tests performed to check correct functioning of changes, useful for an efficient review
Any side note on the changes made: Description of any other change that has been made, which is not directly linked to the issue resolution [e.g. Code clean up/Sonar issue resolution]