feat(nm): add managed GPS mode #5406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdibi
force-pushed
the
feat/MM_managed_gps
branch
from
8f9c542
to
5846b9c
Compare
mattdibi
force-pushed
the
feat/MM_managed_gps
branch
from
8e8460b
to
9a59850
Compare
mattdibi
added
backport docs-release-5.6
backport release-5.6.0
and removed
backport docs-release-5.6
labels
This was referenced Oct 3, 2024
mattdibi
force-pushed
the
feat/MM_managed_gps
branch
from
a919035
to
d24773d
Compare
kura/org.eclipse.kura.nm/src/main/java/org/eclipse/kura/nm/KuraModemGPSMode.java
Show resolved
Hide resolved
pierantoniomerlino
approved these changes
Oct 4, 2024
eclipse-kura-bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
* feat: update isGPSSupported method to correctly report support * feat: add new managed GPS mode for modems * test: add unit tests for the newly introduced modes * refactor: more consistent enum convention * style: add copyright header * style: fix date * docs: fix copyright headers * style: fix copyright headers (cherry picked from commit a847bfd)
MMaiero
pushed a commit
that referenced
this pull request
Oct 7, 2024
* feat: update isGPSSupported method to correctly report support * feat: add new managed GPS mode for modems * test: add unit tests for the newly introduced modes * refactor: more consistent enum convention * style: add copyright header * style: fix date * docs: fix copyright headers * style: fix copyright headers (cherry picked from commit a847bfd)
MMaiero
pushed a commit
that referenced
this pull request
Oct 7, 2024
feat(nm): add managed GPS mode (#5406) * feat: update isGPSSupported method to correctly report support * feat: add new managed GPS mode for modems * test: add unit tests for the newly introduced modes * refactor: more consistent enum convention * style: add copyright header * style: fix date * docs: fix copyright headers * style: fix copyright headers (cherry picked from commit a847bfd) Co-authored-by: Mattia Dal Ben <mattdibi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new mode for handling the modem's GPS, allowing ModemManager to take control of the serial port and thus open the way for us to create a new PositionProvider that retrieves the position information from ModemManager.
This new mode leverages the following two ModemManager location sources:
Once these two are enabled ModemManager will take control of the GPS communication and start parsing the data, allowing clients to retrieve the informations via the "GetLocation" DBus method.
Before this PR (see #4633) we were only using the
MM_MODEM_LOCATION_SOURCE_GPS_UNMANAGEDmode, which took care of setting up the GPS for the modem but left the serial connection free for other services to connect to (eggpsd).Note: to avoid breaking changes in the snapshot, instead of substituting the
net.interface.[deviceId].config.gpsEnabledparameter with an enum, I left it untouched and added thenet.interface.[deviceId].config.gpsModeparameter. It's a little bit more clunky to use but doesn't break snapshot compatibility with older versions. ThegpsModeparameter is optional, when not specified it defaults to theUNMANAGEDmode, preserving the current behaviour.Since we added this new parameter, the
isGpsSupported()method in Kura's API doesn't contain all the required informations anymore. We'll need to add to the APIs a newgetSupportedGPSModes()method to know what mode we can set for the modem at hand. This new API will be introduced in a future separate PR.