feat: added gnssType to position rest service #5429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SimoneFiorani <simone.fiorani@abinsula.com>
Signed-off-by: SimoneFiorani <simone.fiorani@abinsula.com>
| @@ -84,7 +84,7 @@ public void unsetRequestHandlerRegistry(final RequestHandlerRegistry registry) { | |||
| @Produces(MediaType.APPLICATION_JSON) | |||
| public PositionDTO getPosition() { | |||
| if (positionServiceImpl.isLocked()) { | |||
| return new PositionDTO(positionServiceImpl.getPosition()); | |||
| return new PositionDTO(positionServiceImpl.getPosition(), positionServiceImpl.getGnssType()); | |||
There was a problem hiding this comment.
I know that it isn't related to this PR and it is a detail, but I'd call this getGnssTypes or getGnssTypeSet instead of getGnssType since it returns a set not a single value.
| /* | ||
| * Returns the GNSS Type used to retrieve position information | ||
| */ | ||
| public Set<String> getGnssType() { |
pierantoniomerlino
approved these changes
Oct 15, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-5.6.0 release-5.6.0
# Navigate to the new working tree
cd .worktrees/backport-release-5.6.0
# Create a new branch
git switch --create backport-5429-to-release-5.6.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c82bbd28e7d430e860d9ee0e50d7e043762208b8
# Push it to GitHub
git push --set-upstream origin backport-5429-to-release-5.6.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-5.6.0Then, create a pull request where the |
sfiorani
added a commit
to sfiorani/kura
that referenced
this pull request
Oct 15, 2024
* feat: added gnssType to position rest service Signed-off-by: SimoneFiorani <simone.fiorani@abinsula.com> * refactor: modified how the gnsstype info is retrieved Signed-off-by: SimoneFiorani <simone.fiorani@abinsula.com> --------- Signed-off-by: SimoneFiorani <simone.fiorani@abinsula.com> (cherry picked from commit c82bbd2)
sfiorani
added a commit
to sfiorani/kura
that referenced
this pull request
Oct 15, 2024
…se-kura#5429) * feat: added gnssType to position rest service Signed-off-by: SimoneFiorani <simone.fiorani@abinsula.com> * refactor: modified how the gnsstype info is retrieved Signed-off-by: SimoneFiorani <simone.fiorani@abinsula.com> --------- Signed-off-by: SimoneFiorani <simone.fiorani@abinsula.com> (cherry picked from commit c82bbd2)
pierantoniomerlino
pushed a commit
that referenced
this pull request
Oct 16, 2024
#5449) * feat: added gnssType to position rest service [backport 5.6.0] (#5429) * feat: added gnssType to position rest service Signed-off-by: SimoneFiorani <simone.fiorani@abinsula.com> * refactor: modified how the gnsstype info is retrieved Signed-off-by: SimoneFiorani <simone.fiorani@abinsula.com> --------- Signed-off-by: SimoneFiorani <simone.fiorani@abinsula.com> (cherry picked from commit c82bbd2) * fix: remaining cherry-pick confilct removed Signed-off-by: SimoneFiorani <simone.fiorani@abinsula.com> --------- Signed-off-by: SimoneFiorani <simone.fiorani@abinsula.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Position Rest Service to include also the GNSS Type introduced in #5381 . Now the
getPositionGET call returns also the GNSS Type if available.Related Issue:
Description of the solution adopted:
Screenshots:
Manual Tests:
Any side note on the changes made: