Remove SModelExtension interface
#387
Milestone
Comments
|
Yes, we can write notes in the documentation of the respective interfaces instead. Feel free to create a PR if you have time. I am quite packed in this and next week. |
tortmayr
added a commit
that referenced
this issue
Oct 6, 2023
Remove the empty `SModelExtensionInterface` and adapt type doc of feature extension interfaces. Fixes #387
tortmayr
added a commit
that referenced
this issue
Oct 6, 2023
Remove the empty `SModelExtension` interface and adapt type doc of feature extension interfaces. Fixes #387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
SModelExtensioninterface in its current form serves no purpose.I guess the original idea was to use this as marker interface for all model feature extensions.
However, the concept of empty marker interfaces is something that works well in other strongly-typed languages e.g. Java but
does not translate to typescript.
Since you cannot use an instanceof check for interfaces (and a typeguard for an empty interface is also not an option)
the interface effectively has no purpose. We should probably just remove it before the 1.0.0 release.
@spoenemann wdyt?
The text was updated successfully, but these errors were encountered: