Implemented request/response actions, code cleanup #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planger
approved these changes
Aug 30, 2019
There was a problem hiding this comment.
Nice, thank you very much! I think especially request / response actions will come in handy for several use cases and avoiding model updates for commands that don't change anything in the model may have a positive impact on performance.
I only found a very minor suggestion inline regarding the naming. Other than that, this looks great to me!
JanKoehnlein
approved these changes
Sep 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8, fixes #85.
RequestActionandResponseActioninterfaces.requestmethod toIActionDispatcherto dispatch requests and wait for the response.Viewerin three classesModelViewer,HiddenModelViewer,PopupModelViewer.causeaction.causeaction to the viewer and its decorators so they can link any created response action with the original request.ModelRequestCommandto ease the implementation of requests for model details.getSelectionandgetViewporttoLocalModelSourcebased on corresponding request/response actions.